From: Sam Ravnborg <sam@ravnborg.org>
To: Marco <marco.stornelli@gmail.com>
Cc: Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux Embedded <linux-embedded@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Daniel Walker <dwalker@soe.ucsc.edu>
Subject: Re: [PATCH 08/14] Pramfs: Makefile and Kconfig
Date: Sat, 13 Jun 2009 15:56:04 +0200 [thread overview]
Message-ID: <20090613135604.GB30053@uranus.ravnborg.org> (raw)
In-Reply-To: <4A33A802.8040507@gmail.com>
> +
> +config PRAMFS_NOWP
> + bool "Disable PRAMFS write protection"
> + depends on PRAMFS
> + default n
> + help
> + Say Y here to disable the write protect feature of PRAMFS.
n is default so "default n" is not needed.
If you reverse the logic (and add a default y) then..
> +ifneq ($(CONFIG_PRAMFS_NOWP),y)
> +pramfs-objs += wprotect.o
> +endif
This is a trivial:
pramfs-$(PRAMFS_WRITE_PROTECT) += wprotect.o
(I renamed the option to something more descriptive - please do so in the abvoe).
> +++ linux-2.6.30/fs/pramfs/Makefile 2009-04-19 11:58:51.000000000 +0200
> @@ -0,0 +1,13 @@
> +#
> +# Makefile for the linux pram-filesystem routines.
> +#
> +
> +obj-$(CONFIG_PRAMFS) += pramfs.o
> +obj-$(CONFIG_TEST_MODULE) += pramfs_test.o
> +
> +pramfs-objs := balloc.o dir.o file.o inode.o namei.o super.o symlink.o
Use:
pramfs-y := balloc.o ...
This match usa later in this file.
> +
> +ifneq ($(CONFIG_PRAMFS_NOWP),y)
> +pramfs-objs += wprotect.o
> +endif
> +pramfs-$(CONFIG_PRAMFS_XIP) += xip.o
Sam
next prev parent reply other threads:[~2009-06-13 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-13 13:22 [PATCH 08/14] Pramfs: Makefile and Kconfig Marco
2009-06-13 13:56 ` Sam Ravnborg [this message]
2009-06-14 7:15 ` Marco
2009-06-13 14:02 ` Daniel Walker
2009-06-14 7:16 ` Marco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090613135604.GB30053@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=dwalker@soe.ucsc.edu \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.stornelli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).