From: Christoph Hellwig <hch@infradead.org>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: open-osd mailing-list <osd-dev@open-osd.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] exofs: Avoid using file_fsync()
Date: Mon, 15 Jun 2009 09:50:45 -0400 [thread overview]
Message-ID: <20090615135044.GA2553@infradead.org> (raw)
In-Reply-To: <4A364D15.1080105@panasas.com>
On Mon, Jun 15, 2009 at 04:31:01PM +0300, Boaz Harrosh wrote:
> + ret = write_inode_now(inode, 0);
You shouldn't need a write_inode_now, but rather just a similar
sync_inode call as in ext2 or the new simple_fsync as data was
already written by the VFS.
> + /* This is a good place to write the sb */
> + /* TODO: Sechedule an sb-sync on create */
> + sb = inode->i_sb;
> + lock_super(sb);
> + if (sb->s_dirt && sb->s_op->write_super)
> + sb->s_op->write_super(sb);
> + unlock_super(sb);
fsync is not a really good place for a sb write normally. What metadata
in the superblock is needed related to syncing a single file in btrfs?
next prev parent reply other threads:[~2009-06-15 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-15 13:31 [PATCH] exofs: Avoid using file_fsync() Boaz Harrosh
2009-06-15 13:50 ` Christoph Hellwig [this message]
2009-06-15 14:30 ` Boaz Harrosh
2009-06-15 16:52 ` Boaz Harrosh
2009-06-15 17:07 ` [PATCH version 2] " Boaz Harrosh
2009-06-15 17:21 ` [PATCH] " Jeff Garzik
2009-06-15 17:23 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615135044.GA2553@infradead.org \
--to=hch@infradead.org \
--cc=bharrosh@panasas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=osd-dev@open-osd.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).