From: Christoph Hellwig <hch@infradead.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/4] VFS: Add VFS helper functions for setting up private namespaces
Date: Thu, 18 Jun 2009 16:55:47 -0400 [thread overview]
Message-ID: <20090618205547.GA10932@infradead.org> (raw)
In-Reply-To: <20090618192500.19433.90622.stgit@heimdal.trondhjem.org>
On Thu, Jun 18, 2009 at 12:25:01PM -0700, Trond Myklebust wrote:
> /* spinlock for vfsmount related operations, inplace of dcache_lock */
> __cacheline_aligned_in_smp DEFINE_SPINLOCK(vfsmount_lock);
> +EXPORT_SYMBOL(vfsmount_lock);
This is not mentioned in the patch description and also doesn't seem
to be used in the following patches.
Exporting it is a really bad idea anyway as it protects data structures
that should not be exposed to filesystems.
next prev parent reply other threads:[~2009-06-18 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 19:25 [PATCH 0/4] NFS private namespace patchset Trond Myklebust
2009-06-18 19:25 ` [PATCH 2/4] NFSv4: Replace nfs4_path_walk() with VFS path lookup in a private namespace Trond Myklebust
2009-06-18 19:25 ` [PATCH 3/4] NFS: Fix nfs_path() to always return a '/' at the beginning of the path Trond Myklebust
[not found] ` <20090618192500.19433.16770.stgit-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-18 19:25 ` [PATCH 4/4] NFS: Correct the NFS mount path when following a referral Trond Myklebust
2009-06-18 19:25 ` [PATCH 1/4] VFS: Add VFS helper functions for setting up private namespaces Trond Myklebust
2009-06-18 20:55 ` Christoph Hellwig [this message]
2009-06-18 21:43 ` Trond Myklebust
[not found] ` <1245361382.8756.47.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-19 7:43 ` Christoph Hellwig
2009-06-18 19:40 ` [PATCH 0/4] NFS private namespace patchset Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090618205547.GA10932@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).