linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
	akpm@linux-foundation.org, jack@suse.cz, richard@rsk.demon.co.uk,
	damien.wyart@free.fr, dedekind1@gmail.com, fweisbec@gmail.com
Subject: Re: [PATCH 0/15] Per-bdi writeback flusher threads v10
Date: Fri, 19 Jun 2009 07:01:13 +0200	[thread overview]
Message-ID: <20090619050113.GD11363@kernel.dk> (raw)
In-Reply-To: <1245386680.2560.416.camel@ymzhang>

On Fri, Jun 19 2009, Zhang, Yanmin wrote:
> > > > Sorry I should have made that more clear when posting v11. This patch
> > > > wont fully solve the problem, however the v11 patch series should. So if
> > > > you test with that, hopefully all soft hangs should be gone.
> > > Ok. I will start new testing against V11. I also add some debugging codes into
> > > V11.
> > 
> > Great, thanks! There's a small issue with v11 that you should be aware
> > of. The test for bdi_add_default_flusher_task() was inverted. I'm
> > attaching a diff at the end. The interesting bit is the 2nd hunk of
> > backing-dev.c, the others are just a cleanup.
> Jens,
> 
> I did entensive testing with fio (especially the aio randread which triggers
> the hang)/ffsb and a couple of other testing and didn't hit the hang issue.
> So V11 does fix the issue.

Great!

> From performance point of view, there is no big difference than old versions.

That's fine too, it's only been bug fixes the last few revisions. I'll
tag a v12 with the small fix.

-- 
Jens Axboe


  reply	other threads:[~2009-06-19  5:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-12 12:54 [PATCH 0/15] Per-bdi writeback flusher threads v10 Jens Axboe
2009-06-12 12:54 ` [PATCH 01/15] block: don't overwrite bdi->state after bdi_init() has been run Jens Axboe
2009-06-12 12:54 ` [PATCH 02/15] btrfs: properly register fs backing device Jens Axboe
2009-06-12 12:54 ` [PATCH 03/15] ubifs: register backing_dev_info Jens Axboe
2009-06-12 12:54 ` [PATCH 04/15] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-06-12 12:54 ` [PATCH 05/15] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-06-12 12:54 ` [PATCH 06/15] writeback: get rid of pdflush completely Jens Axboe
2009-06-12 12:54 ` [PATCH 07/15] writeback: separate the flushing state/task from the bdi Jens Axboe
2009-06-12 12:54 ` [PATCH 08/15] writeback: support > 1 flusher thread per bdi Jens Axboe
2009-06-12 12:54 ` [PATCH 09/15] writeback: allow sleepy exit of default writeback task Jens Axboe
2009-06-12 12:54 ` [PATCH 10/15] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-06-12 12:54 ` [PATCH 11/15] writeback: add name to backing_dev_info Jens Axboe
2009-06-12 12:54 ` [PATCH 12/15] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-06-12 12:54 ` [PATCH 13/15] writeback: restart bdi list scan on allocation failure Jens Axboe
2009-06-12 12:54 ` [PATCH 14/15] writeback: convert bdi_lock to a spinlock Jens Axboe
2009-06-12 12:54 ` [PATCH 15/15] writeback: use spin_trylock() in bdi_writeback_all() for WB_SYNC_NONE Jens Axboe
2009-06-16  1:06 ` [PATCH 0/15] Per-bdi writeback flusher threads v10 Zhang, Yanmin
2009-06-16  8:00   ` Jens Axboe
2009-06-16 19:53     ` Jens Axboe
2009-06-18  1:01       ` Zhang, Yanmin
2009-06-18  5:13         ` Jens Axboe
2009-06-18  5:19           ` Zhang, Yanmin
2009-06-18 12:35             ` Jens Axboe
2009-06-19  4:44               ` Zhang, Yanmin
2009-06-19  5:01                 ` Jens Axboe [this message]
2009-06-17  1:35     ` Zhang, Yanmin
2009-06-17  4:21       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090619050113.GD11363@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=damien.wyart@free.fr \
    --cc=david@fromorbit.com \
    --cc=dedekind1@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard@rsk.demon.co.uk \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).