Re: [PATCH 1/4] VFS: Add VFS helper functions for setting up private namespaces

[Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>]

On Thu, Jun 18, 2009 at 02:43:02PM -0700, Trond Myklebust wrote:
> On Thu, 2009-06-18 at 16:55 -0400, Christoph Hellwig wrote:
> > On Thu, Jun 18, 2009 at 12:25:01PM -0700, Trond Myklebust wrote:
> > >  /* spinlock for vfsmount related operations, inplace of dcache_lock */
> > >  __cacheline_aligned_in_smp DEFINE_SPINLOCK(vfsmount_lock);
> > > +EXPORT_SYMBOL(vfsmount_lock);
> > 
> > This is not mentioned in the patch description and also doesn't seem
> > to be used in the following patches.
> > 
> > Exporting it is a really bad idea anyway as it protects data structures
> > that should not be exposed to filesystems.
> 
> It is used by the inlined function put_mnt_ns(). It would be trivial to
> make that an extern, and avoid the need for the vfsmount_lock export.
> Would that be acceptable?

I think moving it out of line is much better.  You can also merged it
into __put_mnt_ns while you're at it.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html