From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4] VFS: Add VFS helper functions for setting up private namespaces Date: Fri, 19 Jun 2009 03:43:10 -0400 Message-ID: <20090619074310.GA25197@infradead.org> References: <20090618192500.19433.16770.stgit@heimdal.trondhjem.org> <20090618192500.19433.90622.stgit@heimdal.trondhjem.org> <20090618205547.GA10932@infradead.org> <1245361382.8756.47.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Al Viro , Linus Torvalds , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Trond Myklebust Return-path: Content-Disposition: inline In-Reply-To: <1245361382.8756.47.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Jun 18, 2009 at 02:43:02PM -0700, Trond Myklebust wrote: > On Thu, 2009-06-18 at 16:55 -0400, Christoph Hellwig wrote: > > On Thu, Jun 18, 2009 at 12:25:01PM -0700, Trond Myklebust wrote: > > > /* spinlock for vfsmount related operations, inplace of dcache_lock */ > > > __cacheline_aligned_in_smp DEFINE_SPINLOCK(vfsmount_lock); > > > +EXPORT_SYMBOL(vfsmount_lock); > > > > This is not mentioned in the patch description and also doesn't seem > > to be used in the following patches. > > > > Exporting it is a really bad idea anyway as it protects data structures > > that should not be exposed to filesystems. > > It is used by the inlined function put_mnt_ns(). It would be trivial to > make that an extern, and avoid the need for the vfsmount_lock export. > Would that be acceptable? I think moving it out of line is much better. You can also merged it into __put_mnt_ns while you're at it. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html