linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize
       [not found] <20090423192512.GA22819@lst.de>
@ 2009-06-19  8:30 ` Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2009-06-19  8:30 UTC (permalink / raw)
  To: viro; +Cc: linux-fsdevel, reiserfs-devel

Reiserfs doesn't use lock_super anywhere internally, and ->remount_fs
which calls reiserfs_resize does have it currently but also expects it
to be held on return, so there's no business for the unlock_super here.


Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked by Edward Shishkin <edward.shishkin@gmail.com>

Index: linux-2.6/fs/reiserfs/resize.c
===================================================================
--- linux-2.6.orig/fs/reiserfs/resize.c	2009-04-23 21:23:25.631074621 +0200
+++ linux-2.6/fs/reiserfs/resize.c	2009-04-23 21:23:29.435949732 +0200
@@ -82,7 +82,6 @@ int reiserfs_resize(struct super_block *
 		if (reiserfs_allocate_list_bitmaps(s, jbitmap, bmap_nr_new) < 0) {
 			printk
 			    ("reiserfs_resize: unable to allocate memory for journal bitmaps\n");
-			unlock_super(s);
 			return -ENOMEM;
 		}
 		/* the new journal bitmaps are zero filled, now we copy in the bitmap

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-06-19  8:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20090423192512.GA22819@lst.de>
2009-06-19  8:30 ` [PATCH] reiserfs: remove stray unlock_super in reiserfs_resize Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).