From: Al Viro <viro@ZenIV.linux.org.uk>
To: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [RESEND][PATCH] lseek: remove i_mutex
Date: Thu, 25 Jun 2009 05:54:52 +0100 [thread overview]
Message-ID: <20090625045452.GA8633@ZenIV.linux.org.uk> (raw)
In-Reply-To: <6.0.0.20.2.20090625115833.05a9ce10@172.19.0.2>
On Thu, Jun 25, 2009 at 01:41:10PM +0900, Hisashi Hifumi wrote:
> Hi,
>
> Following patch removes i_mutex from generic_file_llseek.
> I think the reason of protecting lseek with i_mutex is just
> touching i_size (and f_pos) atomically.
NAK. There's also a lot of fun with directories - readdir() vs. llseek().
next prev parent reply other threads:[~2009-06-25 4:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 4:41 [RESEND][PATCH] lseek: remove i_mutex Hisashi Hifumi
2009-06-25 4:54 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-05-14 0:26 Hisashi Hifumi
2009-05-14 5:57 ` Eric Dumazet
2009-02-03 8:04 [RESEND] [PATCH] " Hisashi Hifumi
2009-02-05 20:05 ` Andrew Morton
2009-02-06 0:20 ` Hisashi Hifumi
2009-02-06 0:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090625045452.GA8633@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).