From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH] sanitize xattr handler prototypes Date: Fri, 26 Jun 2009 01:47:56 -0700 Message-ID: <20090626084756.GA4478@mail.oracle.com> References: <20090625173543.GA7073@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from acsinet12.oracle.com ([141.146.126.234]:50756 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbZFZItD (ORCPT ); Fri, 26 Jun 2009 04:49:03 -0400 Content-Disposition: inline In-Reply-To: <20090625173543.GA7073@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jun 25, 2009 at 07:35:44PM +0200, Christoph Hellwig wrote: > Add a flags argument to strcut xattr_handler and pass it to all xattr > handler methods. This allows using the same methods for multiple > handlers, e.g. for the ACL methods which perform exactly the same action > for the access and default ACLs, just using a different underlying > attribute. With a little more groundwork it'll also allow sharing the > methods for the regular user/trusted/secure handlers in extN, ocfs2 and > jffs2 like it's already done for xfs in this patch. Acked-by: Joel Becker -- "The one important thing i have learned over the years is the difference between taking one's work seriously and taking one's self seriously. The first is imperative and the second is disastrous." -Margot Fonteyn Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127