From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Lokier Subject: Re: [PATCH] Added CONFIG_VFAT_FS_DUALNAMES option Date: Sun, 28 Jun 2009 22:57:54 +0100 Message-ID: <20090628215754.GA29896@shareable.org> References: <19013.8005.541836.436991@samba.org> <19014.56477.311713.975403@samba.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Engelhardt , Linux Kernel Mailing List , OGAWA Hirofumi , john.lanza@linux.com, linux-fsdevel@vger.kernel.org, Dave Kleikamp , Steve French , Mingming Cao , Paul McKenney To: tridge@samba.org Return-path: Received: from mail2.shareable.org ([80.68.89.115]:57942 "EHLO mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbZF1V57 (ORCPT ); Sun, 28 Jun 2009 17:57:59 -0400 Content-Disposition: inline In-Reply-To: <19014.56477.311713.975403@samba.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: tridge@samba.org wrote: > Hi Jan, > > > Can't we make this a runtime option? > > John may be able to give you a more detailed answer, but the short > answer is that it is much safer legally to not have the code in the > binary kernel image at all. Understood. For those of us who don't want to omit the code, because we like compatibility and we're not in affected countries, or for research, it would be useful to have it as a mount option. So there should be these compile-time options: 1. CONFIG_VFAT_FS_DUALNAMES disabled: Don't create shortnames. 2. CONFIG_VFAT_FS_DUALNAMES enabled: Create shortnames, unless mount option "dualnames=no" is given, in which case that mount behaves as if CONFIG_VFAT_FS_DUALNAMES is disabled. -- Jamie