From: Jens Axboe <jens.axboe@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Mike Snitzer <snitzer@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alasdair G Kergon <agk@redhat.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-ide@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [dm-devel] REQUEST for new 'topology' metrics to be moved out of the 'queue' sysfs directory.
Date: Mon, 29 Jun 2009 13:41:21 +0200 [thread overview]
Message-ID: <20090629114121.GH23611@kernel.dk> (raw)
In-Reply-To: <b0aa07ac85efd6040501e4ea875176a3.squirrel@neil.brown.name>
On Mon, Jun 29 2009, NeilBrown wrote:
> On Mon, June 29, 2009 8:18 pm, Jens Axboe wrote:
> > On Sat, Jun 27 2009, Neil Brown wrote:
> >> > There's no such thing as first or second class block devices. The fact
> >> > that drivers using ->make_request_fn directly do not utilize the full
> >> > scope of the queue isn't a very interesting fact, imho.
> >>
> >> Your phrase "drivers using ->make_request_fn directly" seems to
> >> suggest you are looking at things very differently to me.
> >>
> >> From my perspective, all drivers use ->make_request_fn equally.
> >> Some set it to "__make_request", some to "md_make_request", others to
> >> "dm_request" or "loop_make_request" etc.
> >
> > Neil, will you please stop these silly games. Stop trying to invent
> > differences based on interpretations of what you read into my replies.
>
>
> We do seem to be having trouble communicating don't we :-(
> Be assured that it is not my intention to play games, silly or otherwise.
>
> Maybe I should just try sending you patches. Maybe that will
> make my meaning clearer.
>
> For the moment, I'm much more interested in the other question,
> that of whether I can avoid having a 'queue' directory introduced into
> md/dm/etc device directories in sysfs.
We already talked about this, several times. My answer is that it seems
pointless to begin with internally, and externally it just makes the API
worse since tools then have to know which device type they are talking
to.
So I still see absolutely zero point in making such a change, quite the
opposite.
--
Jens Axboe
next prev parent reply other threads:[~2009-06-29 11:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-25 3:58 REQUEST for new 'topology' metrics to be moved out of the 'queue' sysfs directory Neil Brown
2009-06-25 8:00 ` Martin K. Petersen
2009-06-25 11:07 ` [dm-devel] " NeilBrown
2009-06-25 11:36 ` John Robinson
2009-06-25 17:43 ` Martin K. Petersen
2009-06-25 12:17 ` berthiaume_wayne
2009-06-25 17:38 ` Martin K. Petersen
2009-06-25 17:46 ` Linus Torvalds
2009-06-25 19:34 ` Jens Axboe
2009-06-26 11:58 ` [dm-devel] " Neil Brown
2009-06-26 14:48 ` Martin K. Petersen
2009-07-07 1:47 ` [dm-devel] " Neil Brown
2009-07-07 5:29 ` Martin K. Petersen
2009-07-09 0:42 ` Neil Brown
2009-07-07 22:06 ` Bill Davidsen
2009-06-25 19:40 ` [dm-devel] " Jens Axboe
2009-06-26 12:41 ` Neil Brown
2009-06-26 12:50 ` Jens Axboe
2009-06-26 13:16 ` NeilBrown
2009-06-26 13:27 ` Jens Axboe
2009-06-26 13:41 ` NeilBrown
2009-06-26 13:49 ` Jens Axboe
2009-06-27 12:50 ` Neil Brown
2009-06-26 13:23 ` [dm-devel] " NeilBrown
2009-06-26 13:29 ` Jens Axboe
2009-06-27 12:32 ` Neil Brown
2009-06-29 10:18 ` [dm-devel] " Jens Axboe
2009-06-29 10:52 ` NeilBrown
2009-06-29 11:41 ` Jens Axboe [this message]
2009-06-29 12:45 ` Boaz Harrosh
2009-06-29 12:52 ` Jens Axboe
2009-06-29 23:09 ` Andreas Dilger
2009-07-01 0:29 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629114121.GH23611@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=neilb@suse.de \
--cc=snitzer@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).