linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Bob Peterson <rpeterso@redhat.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: Inconsistent consistency checkers
Date: Tue, 30 Jun 2009 23:26:48 +0200	[thread overview]
Message-ID: <20090630212648.GH3248@webber.adilger.int> (raw)
In-Reply-To: <778473364.633771246371379556.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>

On Jun 30, 2009  10:16 -0400, Bob Peterson wrote:
> The rc.sysinit script used on many distros calls fsck specifying
> the "-a" option for the root file system and file systems specified
> to be checked in fstab.  According to the fsck man page, -a is to
> "Automatically repair the file system without any questions".  This
> -a parameter is passed on to the appropriate fsck.XXXX program.
> The problem is, the various fsck programs are inconsistent in how
> they interpret the -a parameter.  Here's a sampling (in alphabetical
> order):
> 
> btrfsck       - Rejects -a and -p (no ancillary command line args).
> fsck.ext2     - Accepts -a but translates it into -p.  Use of -a
>                 is discouraged.  The man page says "It is provided
>                 for backwards compatibility only; it  is  suggested
>                 that people use -p option whenever possible."

I don't quite understand why Ted made "-a" discouraged, but "-p" does
virtually the same thing.  I guess the theory is that "-p" doesn't
fix _everything_, and in some cases "-p" fails and requires manual
intervention.

> fsck.ext3     - Same as ext2
> fsck.ext4     - Same as ext3
> fsck.gfs2     - Rejects both -a and -p.
> fsck.hfs      - Rejects -a, but accepts -p.
> fsck.jfs      - Accepts -a and -p.
> fsck.minix    - Accepts -a but rejects -p.
> fsck.ocfs2    - Rejects both -a and -p.
> fsck.reiserfs - Accepts -a and -p.
> fsck.vfat     - Accepts -a but rejects -p.
> fsck.xfs      - Is completely a no-op with a good return code, the
>                 theory being that its journal recovery should make
>                 the fs sane.  If you REALLY want to check or repair
>                 your xfs file system, you need to run xfs_check or
>                 xfs_repair.

IMHO any fsck.* should at least do a minimal check of the filesystem,
as fsck.ext* does without "-f" (superblock, basic filesystem structures,
an on-disk error flag, in a second or two) so that the filesystem isn't
auto-mounted on reboot with serious corruption and possibly causing worse
corruption.  This is doubly true with any filesystem that has the
equivalent of "errors=panic" functionality, because it will otherwise
cause a cycle of mount-error-panic-reboot-mount-... until someone arrives
in the morning to find out what is broken.

Also, without either an on-boot check, or online repair (btrfsck?) it
isn't easy to check root filesystems, and lots of systems only configure
a single root filesystem these days.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


      reply	other threads:[~2009-06-30 21:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1212595845.633651246371270160.JavaMail.root@zmail06.collab.prod.int.phx2.redhat.com>
2009-06-30 14:16 ` Inconsistent consistency checkers Bob Peterson
2009-06-30 21:26   ` Andreas Dilger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090630212648.GH3248@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).