From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 05/10] writeback: support > 1 flusher thread per bdi Date: Mon, 6 Jul 2009 14:22:12 +0200 Message-ID: <20090706122211.GO23611@kernel.dk> References: <1245926523-21959-1-git-send-email-jens.axboe@oracle.com> <1245926523-21959-6-git-send-email-jens.axboe@oracle.com> <4A51EB8D.1070300@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org, akpm@linux-foundation.org, jack@suse.cz, yanmin_zhang@linux.intel.com, richard@rsk.demon.co.uk, damien.wyart@free.fr, fweisbec@gmail.com, Alan.Brunelle@hp.com To: Artem Bityutskiy Return-path: Received: from brick.kernel.dk ([93.163.65.50]:53559 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbZGFMWJ (ORCPT ); Mon, 6 Jul 2009 08:22:09 -0400 Content-Disposition: inline In-Reply-To: <4A51EB8D.1070300@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 06 2009, Artem Bityutskiy wrote: > Jens Axboe wrote: >> +static struct bdi_work *bdi_alloc_work(struct super_block *sb, long nr_pages, >> + enum writeback_sync_modes sync_mode) >> +{ >> + struct bdi_work *work; >> + >> + work = kmalloc(sizeof(*work), GFP_ATOMIC); >> + if (work) >> + bdi_work_init(work, sb, nr_pages, sync_mode); >> - wb_start_writeback(&bdi->wb, sb, nr_pages, sync_mode); >> + return work; >> +} > > Since the caller of this function handles kmalloc failure gracefully, > should we also pass __GFP_NOWARN flag to kmalloc() here, in order to > avoid large and scary no-memory complaints? Sure, it can't hurt. -- Jens Axboe