From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] [2/2] Optimize touch_time too Date: Tue, 7 Jul 2009 06:50:16 -0400 Message-ID: <20090707105016.GB23619@infradead.org> References: <20090706924.495556466@firstfloor.org> <20090706192447.9D0531D024A@basil.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Andi Kleen Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:51032 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752214AbZGGKuN (ORCPT ); Tue, 7 Jul 2009 06:50:13 -0400 Content-Disposition: inline In-Reply-To: <20090706192447.9D0531D024A@basil.firstfloor.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 06, 2009 at 09:24:47PM +0200, Andi Kleen wrote: > > Do a similar optimization as earlier for touch_atime. Getting > the lock in mnt_get_write is relatively costly, so try all > avenues to avoid it first. > > This patch is careful to still only update inode fields > inside the lock region. > > This didn't show up in benchmarks, but it's easy enough > to do. > > Signed-off-by: Andi Kleen > > --- > fs/inode.c | 43 +++++++++++++++++++++++-------------------- > 1 file changed, 23 insertions(+), 20 deletions(-) > > Index: linux-2.6.31-rc1-ak/fs/inode.c > =================================================================== > --- linux-2.6.31-rc1-ak.orig/fs/inode.c > +++ linux-2.6.31-rc1-ak/fs/inode.c > @@ -1431,34 +1431,37 @@ void file_update_time(struct file *file) > { > struct inode *inode = file->f_path.dentry->d_inode; > struct timespec now; > - int sync_it = 0; > - int err; > + enum { S_MTIME = 1, S_CTIME = 2, S_VERSION = 4 } sync_it = 0; Looks good, and makes sense to keep thise in sync with file_update_atime.