linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
To: Al Viro <viro@ZenIV.linux.org.uk>, Jens Axboe <jens.axboe@oracle.com>
Cc: linux-fsdevel@vger.kernel.org,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 01/18] VFS: introduce helpers for manipulation s_dirty flag
Date: Thu, 09 Jul 2009 11:48:29 +0300	[thread overview]
Message-ID: <20090709084829.12122.7367.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20090709084822.12122.79749.sendpatchset@localhost.localdomain>

This patch introduces 3 new VFS helpers: 'mark_sb_dirty()',
'mark_sb_clean()', and 'is_sb_dirty()'. The helpers simply
set 'sb->s_dirt' or test 'sb->s_dirt'. The plan is to make
every FS use these helpers instead of manipulating
'sb->s_dirt' directly. And the further plan is to stop the
periodic write-back when there is no dirt.

This patch is just a preparation for further periodic write-back
timer optimizations. No functional changes yet.

Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
---
 include/linux/fs.h |   17 +++++++++++++++++
 1 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 8f0478c..d98d8d1 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -1789,6 +1789,23 @@ extern int get_sb_pseudo(struct file_system_type *, char *,
 extern void simple_set_mnt(struct vfsmount *mnt, struct super_block *sb);
 int __put_super_and_need_restart(struct super_block *sb);
 
+/*
+ * Note, VFS does not provide any protection for the super block clean/dirty
+ * state. File-systems should take care of this.
+ */
+static inline void mark_sb_dirty(struct super_block *sb)
+{
+	sb->s_dirt = 1;
+}
+static inline void mark_sb_clean(struct super_block *sb)
+{
+	sb->s_dirt = 0;
+}
+static inline int is_sb_dirty(struct super_block *sb)
+{
+	return sb->s_dirt;
+}
+
 /* Alas, no aliases. Too much hassle with bringing module.h everywhere */
 #define fops_get(fops) \
 	(((fops) && try_module_get((fops)->owner) ? (fops) : NULL))
-- 
1.6.0.6


  reply	other threads:[~2009-07-09  6:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-09  8:48 [PATCH v3 00/18] periodic write-back timer optimization Artem Bityutskiy
2009-07-09  8:48 ` Artem Bityutskiy [this message]
2009-07-09  8:48 ` [PATCH v3 02/18] AFFS: do not manipulate s_dirt directly Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 03/18] BFS: " Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 04/18] EXOFS: " Artem Bityutskiy
2009-07-12  9:53   ` Boaz Harrosh
2009-07-12 14:02     ` Artem Bityutskiy
2009-07-09  8:48 ` [PATCH v3 05/18] EXT2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 06/18] EXT4: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 07/18] FAT: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 08/18] HFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 09/18] HFSPLUS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 10/18] JFFS2: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 11/18] NILFS: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 12/18] reiserfs: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 13/18] SYSV: " Artem Bityutskiy
2009-07-09  8:49 ` [PATCH v3 14/18] UDF: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 15/18] UFS: " Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 16/18] VFS: use is_sb_dirty helper Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 17/18] rename s_dirt to s_dirty Artem Bityutskiy
2009-07-09  8:50 ` [PATCH v3 18/18] writeback: optimize periodic sync_supers Artem Bityutskiy
2009-07-09 12:37 ` [PATCH v3 00/18] periodic write-back timer optimization Andi Kleen
2009-07-09 13:04   ` Artem Bityutskiy
2009-07-15  6:21 ` Artem Bityutskiy
2009-07-24 15:45   ` Artem Bityutskiy
2009-09-14 15:27     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090709084829.12122.7367.sendpatchset@localhost.localdomain \
    --to=artem.bityutskiy@nokia.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).