From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [rfc][patch 3/4] fs: new truncate sequence Date: Mon, 13 Jul 2009 09:53:24 -0400 Message-ID: <20090713135324.GB3685@infradead.org> References: <20090707154809.GH2714@wotan.suse.de> <20090707163042.GA14947@infradead.org> <20090708063225.GL2714@wotan.suse.de> <20090708104701.GA31419@infradead.org> <20090708123412.GQ2714@wotan.suse.de> <4A54C435.1000503@panasas.com> <20090709075100.GU2714@wotan.suse.de> <4A59A517.1080605@panasas.com> <20090712144717.GA18163@infradead.org> <20090713065917.GO14666@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Boaz Harrosh , linux-fsdevel@vger.kernel.org, Jan Kara , LKML , linux-mm@kvack.org To: Nick Piggin Return-path: Content-Disposition: inline In-Reply-To: <20090713065917.GO14666@wotan.suse.de> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Jul 13, 2009 at 08:59:17AM +0200, Nick Piggin wrote: > Agreed, if it is a common sequence / requirement for filesystems > then of course I will not object to a helper to make things clearer > or share code. > > I would like to see inode_setattr renamed into simple_setattr, and > then also .setattr made mandatory, so I don't like to cut code out > of inode_setattr which makes it unable to be the simple_setattr > after the old truncate code is removed. But inode_setattr isn't anything like simple_setattr. Except for the truncate special case it's really just a helper to copy values into the inode. It doesn't even even have the same prototype as ->setattr. A simple_setattr would look like the following: int simple_setattr(struct dentry *dentry, struct iattr *iattr) { struct inode *inode = dentry->d_inode; int error; error = inode_change_ok(inode, iattr); if (error) return error; if ((iattr->ia_valid & ATTR_UID && iattr->ia_uid != inode->i_uid) || (iattr->ia_valid & ATTR_GID && iattr->ia_gid != inode->i_gid)) { if (vfs_dq_transfer(inode, iattr)) return -EDQUOT; } if (iattr->ia_valid & ATTR_ATTR_SIZE && iattr->ia_size !== i_size_read(inode) && inode->i_op->new_truncate) { error = simple_setsize(inode, attr->ia_size); if (error) return error; } return inode_setattr(inode, attr); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org