From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: [PATCH] shmem: call set_page_dirty() with locked page Date: Tue, 14 Jul 2009 17:29:26 +0800 Message-ID: <20090714092926.GA23969@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Hugh Dickins , LKML , linux-fsdevel@vger.kernel.org To: Andrew Morton Return-path: Received: from mga14.intel.com ([143.182.124.37]:46674 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754193AbZGNJ6W (ORCPT ); Tue, 14 Jul 2009 05:58:22 -0400 Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Here set_page_dirty() can be moved into the page lock. CC: Hugh Dickins Signed-off-by: Wu Fengguang --- mm/shmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux.orig/mm/shmem.c +++ linux/mm/shmem.c @@ -1630,8 +1630,8 @@ shmem_write_end(struct file *file, struc if (pos + copied > inode->i_size) i_size_write(inode, pos + copied); - unlock_page(page); set_page_dirty(page); + unlock_page(page); page_cache_release(page); return copied;