From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] shmem: call set_page_dirty() with locked page
Date: Tue, 14 Jul 2009 23:33:08 +0800 [thread overview]
Message-ID: <20090714153250.GA4149@hack> (raw)
In-Reply-To: <20090714092926.GA23969@localhost>
On Tue, Jul 14, 2009 at 05:29:26PM +0800, Wu Fengguang wrote:
>Here set_page_dirty() can be moved into the page lock.
>
>CC: Hugh Dickins <hugh@veritas.com>
>Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
>---
> mm/shmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>--- linux.orig/mm/shmem.c
>+++ linux/mm/shmem.c
>@@ -1630,8 +1630,8 @@ shmem_write_end(struct file *file, struc
> if (pos + copied > inode->i_size)
> i_size_write(inode, pos + copied);
>
>- unlock_page(page);
> set_page_dirty(page);
>+ unlock_page(page);
> page_cache_release(page);
>
> return copied;
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
next prev parent reply other threads:[~2009-07-14 15:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-14 9:29 [PATCH] shmem: call set_page_dirty() with locked page Wu Fengguang
2009-07-14 15:33 ` Américo Wang [this message]
2009-07-16 2:12 ` Wu Fengguang
2009-07-14 18:24 ` Hugh Dickins
2009-07-15 11:10 ` Wu Fengguang
2009-07-15 11:17 ` Wu Fengguang
2009-07-15 13:18 ` Hugh Dickins
2009-07-15 14:04 ` Wu Fengguang
2009-07-15 14:22 ` Hugh Dickins
2009-07-15 14:28 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090714153250.GA4149@hack \
--to=xiyou.wangcong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).