From: Andi Kleen <andi@firstfloor.org>
To: Sage Weil <sage@newdream.net>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 18/20] ceph: debugging
Date: Fri, 17 Jul 2009 20:56:41 +0200 [thread overview]
Message-ID: <20090717185641.GH8046@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0907171010470.23194@cobra.newdream.net>
Good.
Sorry for not doing more (and more serious) reviews, not enough
time right now.
> #define _dout(fmt, args...) \
> pr_debug(" %12.12s:%-4d : " fmt "%s", \
> ceph_file_part(__FILE__, sizeof(__FILE__)), \
> __LINE__, args);
That seems like a wasteful way to do this -- i bet you could
shrink binary size with debugging on considerably if you move
the file_part into a function.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2009-07-17 18:56 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 21:24 [PATCH 00/20] ceph: Ceph distributed file system client v0.10 Sage Weil
2009-07-15 21:24 ` [PATCH 01/20] ceph: documentation Sage Weil
2009-07-15 21:24 ` [PATCH 02/20] ceph: on-wire types Sage Weil
2009-07-15 21:24 ` [PATCH 03/20] ceph: client types Sage Weil
2009-07-15 21:24 ` [PATCH 04/20] ceph: super.c Sage Weil
2009-07-15 21:24 ` [PATCH 05/20] ceph: inode operations Sage Weil
2009-07-15 21:24 ` [PATCH 06/20] ceph: directory operations Sage Weil
2009-07-15 21:24 ` [PATCH 07/20] ceph: file operations Sage Weil
2009-07-15 21:24 ` [PATCH 08/20] ceph: address space operations Sage Weil
2009-07-15 21:24 ` [PATCH 09/20] ceph: MDS client Sage Weil
2009-07-15 21:24 ` [PATCH 10/20] ceph: OSD client Sage Weil
2009-07-15 21:24 ` [PATCH 11/20] ceph: CRUSH mapping algorithm Sage Weil
2009-07-15 21:24 ` [PATCH 12/20] ceph: monitor client Sage Weil
2009-07-15 21:24 ` [PATCH 13/20] ceph: capability management Sage Weil
2009-07-15 21:24 ` [PATCH 14/20] ceph: snapshot management Sage Weil
2009-07-15 21:24 ` [PATCH 15/20] ceph: messenger library Sage Weil
2009-07-15 21:24 ` [PATCH 16/20] ceph: nfs re-export support Sage Weil
2009-07-15 21:24 ` [PATCH 17/20] ceph: ioctls Sage Weil
2009-07-15 21:24 ` [PATCH 18/20] ceph: debugging Sage Weil
2009-07-15 21:24 ` [PATCH 19/20] ceph: debugfs Sage Weil
2009-07-15 21:24 ` [PATCH 20/20] ceph: Kconfig, Makefile Sage Weil
2009-07-16 12:27 ` [PATCH 18/20] ceph: debugging Andi Kleen
2009-07-16 17:17 ` Sage Weil
2009-07-17 18:07 ` Sage Weil
2009-07-17 18:56 ` Andi Kleen [this message]
2009-07-17 19:52 ` Sage Weil
2009-07-17 20:01 ` Andi Kleen
2009-07-17 21:35 ` Sage Weil
2009-07-17 21:51 ` Andi Kleen
2009-07-15 22:05 ` common layout xattr Andreas Dilger
2009-07-15 22:19 ` Sage Weil
2009-07-16 5:13 ` Andreas Dilger
2009-07-16 22:29 ` Sage Weil
2009-07-17 4:45 ` Andreas Dilger
2009-07-18 4:51 ` Sage Weil
2009-07-16 19:27 ` [PATCH 16/20] ceph: nfs re-export support J. Bruce Fields
2009-07-16 19:50 ` Sage Weil
2009-07-16 21:21 ` Trond Myklebust
2009-07-16 22:07 ` Sage Weil
2009-07-17 14:05 ` J. Bruce Fields
2009-07-17 16:49 ` Sage Weil
2009-07-17 16:57 ` J. Bruce Fields
2009-07-16 12:31 ` [PATCH 02/20] ceph: on-wire types Andi Kleen
2009-07-16 16:58 ` Sage Weil
2009-07-16 3:59 ` [PATCH 00/20] ceph: Ceph distributed file system client v0.10 Noah Watkins
2009-07-16 17:03 ` Sage Weil
2009-07-16 12:26 ` Andi Kleen
2009-07-16 17:11 ` Sage Weil
2009-07-18 1:28 ` Chris Wright
2009-07-18 4:39 ` Sage Weil
-- strict thread matches above, loose matches on Subject: below --
2009-03-09 22:40 [PATCH 00/20] ceph: Ceph distributed file system client Sage Weil
2009-03-09 22:40 ` [PATCH 01/20] ceph: documentation Sage Weil
2009-03-09 22:40 ` [PATCH 02/20] ceph: on-wire types Sage Weil
2009-03-09 22:40 ` [PATCH 03/20] ceph: client types Sage Weil
2009-03-09 22:40 ` [PATCH 04/20] ceph: super.c Sage Weil
2009-03-09 22:40 ` [PATCH 05/20] ceph: inode operations Sage Weil
2009-03-09 22:40 ` [PATCH 06/20] ceph: directory operations Sage Weil
2009-03-09 22:40 ` [PATCH 07/20] ceph: file operations Sage Weil
2009-03-09 22:40 ` [PATCH 08/20] ceph: address space operations Sage Weil
2009-03-09 22:40 ` [PATCH 09/20] ceph: MDS client Sage Weil
2009-03-09 22:40 ` [PATCH 10/20] ceph: OSD client Sage Weil
2009-03-09 22:40 ` [PATCH 11/20] ceph: CRUSH mapping algorithm Sage Weil
2009-03-09 22:40 ` [PATCH 12/20] ceph: monitor client Sage Weil
2009-03-09 22:40 ` [PATCH 13/20] ceph: capability management Sage Weil
2009-03-09 22:40 ` [PATCH 14/20] ceph: snapshot management Sage Weil
2009-03-09 22:40 ` [PATCH 15/20] ceph: messenger library Sage Weil
2009-03-09 22:40 ` [PATCH 16/20] ceph: nfs re-export support Sage Weil
2009-03-09 22:40 ` [PATCH 17/20] ceph: ioctls Sage Weil
2009-03-09 22:40 ` [PATCH 18/20] ceph: debugging Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090717185641.GH8046@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).