From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [Patch] pipe: use file_update_time() when hold i_mutex Date: Mon, 20 Jul 2009 14:11:50 -0700 Message-ID: <20090720141150.e9d081ca.akpm@linux-foundation.org> References: <20090706053745.6338.50777.sendpatchset@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, amwang@redhat.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, mszeredi@suse.cz To: Amerigo Wang Return-path: In-Reply-To: <20090706053745.6338.50777.sendpatchset@localhost.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 6 Jul 2009 01:35:30 -0400 Amerigo Wang wrote: > > file_update_time() should be called with i_mutex held, > move it before mutex_unlock(). > Why do you believe that file_update_time() needs i_mutex?