From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 08/19] ceph: address space operations Date: Thu, 23 Jul 2009 21:17:34 +0200 Message-ID: <20090723191734.GF19207@basil.fritz.box> References: <1248292313-31326-2-git-send-email-sage@newdream.net> <1248292313-31326-3-git-send-email-sage@newdream.net> <1248292313-31326-4-git-send-email-sage@newdream.net> <1248292313-31326-5-git-send-email-sage@newdream.net> <1248292313-31326-6-git-send-email-sage@newdream.net> <1248292313-31326-7-git-send-email-sage@newdream.net> <1248292313-31326-8-git-send-email-sage@newdream.net> <1248292313-31326-9-git-send-email-sage@newdream.net> <874ot33ddd.fsf@basil.nowhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Sage Weil Return-path: Received: from one.firstfloor.org ([213.235.205.2]:60059 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbZGWTRf (ORCPT ); Thu, 23 Jul 2009 15:17:35 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Jul 23, 2009 at 11:22:04AM -0700, Sage Weil wrote: > I fixed the bad GFP_KERNEL/uncheck kmalloc. Which was just a struct > pagevec, which we added a while ago to reduce stack usage. Maybe the > stack is a better place for it though? (cifs puts it on the stack...) Sorry forgot to answer that earlier. I would put it on the stack. -Andi -- ak@linux.intel.com -- Speaking for myself only.