From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: [patch 07/12] seq_file: return a negative error code when seq_path_root() fails. Date: Thu, 06 Aug 2009 16:10:12 -0700 Message-ID: <200908062310.n76NACsv012939@imap1.linux-foundation.org> Cc: linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, penguin-kernel@i-love.sakura.ne.jp To: viro@zeniv.linux.org.uk Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:52656 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902AbZHFXSt (ORCPT ); Thu, 6 Aug 2009 19:18:49 -0400 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Tetsuo Handa seq_path_root() is returning a return value of successful __d_path() instead of returning a negative value when mangle_path() failed. This is not a bug so far because nobody is using return value of seq_path_root(). Signed-off-by: Tetsuo Handa Cc: Al Viro Signed-off-by: Andrew Morton --- fs/seq_file.c | 1 + 1 file changed, 1 insertion(+) diff -puN fs/seq_file.c~seq_file-return-a-negative-error-code-when-seq_path_root-fails fs/seq_file.c --- a/fs/seq_file.c~seq_file-return-a-negative-error-code-when-seq_path_root-fails +++ a/fs/seq_file.c @@ -470,6 +470,7 @@ int seq_path_root(struct seq_file *m, st m->count = s - m->buf; return 0; } + err = -ENAMETOOLONG; } } m->count = m->size; _