From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mandeep Singh Baines Subject: Re: [patch 09/12] sendfile: several fixes Date: Thu, 6 Aug 2009 23:12:17 -0700 Message-ID: <20090807061216.GX24668@google.com> References: <200908062310.n76NAFKE012978@imap1.linux-foundation.org> <20090806232418.GA6279@infradead.org> <21c5ff280908061625g3752644dy6c685979312a4b5d@mail.gmail.com> <20090806232944.GA11804@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Robert Love , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig , jlayton@redhat.com Return-path: Received: from smtp-out.google.com ([216.239.45.13]:31341 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753981AbZHGGM1 (ORCPT ); Fri, 7 Aug 2009 02:12:27 -0400 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id n776CQtc014415 for ; Thu, 6 Aug 2009 23:12:27 -0700 Received: from pzk13 (pzk13.prod.google.com [10.243.19.141]) by zps37.corp.google.com with ESMTP id n776COGW019611 for ; Thu, 6 Aug 2009 23:12:24 -0700 Received: by pzk13 with SMTP id 13so665288pzk.8 for ; Thu, 06 Aug 2009 23:12:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20090806232944.GA11804@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Christoph Hellwig (hch@infradead.org) wrote: > On Thu, Aug 06, 2009 at 07:25:56PM -0400, Robert Love wrote: > > On Thu, Aug 6, 2009 at 7:24 PM, Christoph Hellwig wrote: > > > > > The right fix is to not set s_maxbytes to ~0ULL. ?Jeff Layton has sent > > > some patches for that recently. > > Yeah, found it here: http://lkml.org/lkml/2009/7/22/178 > > I agree. > > > > I still think this check is worthwhile, given the signed/unsigned mismatch. > > I think the plan is to change s_maxbytes to be an loff_t which would > eliminate this. I'm not sure if Jeff has sent that patch already. > Yeah, found the discussion here: http://lkml.org/lkml/2009/7/22/241 Cool. Didn't really like this check. It would be nice to remove the check and comment from the next version of this patch.