From: Christoph Hellwig <hch@infradead.org>
To: torvalds@linux-foundation.org, felixb@sgi.com
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: [PULL REQUEST] vfs/xfs: fix freeing of inodes not yet added to the inode cache
Date: Fri, 7 Aug 2009 13:34:23 -0400 [thread overview]
Message-ID: <20090807173423.GA19588@infradead.org> (raw)
Hi Linus, hi Felix,
not sure which way this should go, especially with Al being offline,
it's a fix for an XFS only bug, but mostly touching the VFS.
These three patches fix problems we intorduced when redoing the XFS
inode caching in 2.6.29 (yes, that long ago). The actual fixes are
mostly in inode.c, but in functionality that was only exported in that
way for XFS and doesn't have other users, which the last patch just
mostly splits up a function in XFS to fix the way we delete inodes
that lost the race of adding them to the inode.
As you can see by the Reported-by tags on the last patch tons of people
hit it (probably the most I've ever seen for a single bug), and it's been
harassing us for a long time, so I'd really like to see this getting
into 2.6.31. It's been out on -fsdevel for review for a couple of days.
The following changes since commit 90bc1a658a53f8832ee799685703977a450e5af9:
Linus Torvalds (1):
Merge branch 'upstream' of git://ftp.linux-mips.org/pub/scm/upstream-linus
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/hch/xfs-icache-races.git master
Christoph Hellwig (3):
vfs: fix inode_init_always calling convention
vfs: add __destroy_inode
xfs: fix freeing of inodes not yet added to the inode cache
fs/inode.c | 39 ++++++++------
fs/xfs/xfs_iget.c | 142 +++++++++++++++++++++++++++-------------------------
fs/xfs/xfs_inode.h | 17 ------
include/linux/fs.h | 3 +-
4 files changed, 98 insertions(+), 103 deletions(-)
reply other threads:[~2009-08-07 17:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807173423.GA19588@infradead.org \
--to=hch@infradead.org \
--cc=felixb@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).