From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, hch@infradead.org, rlove@google.com,
msb@google.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org
Subject: Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to signed
Date: Mon, 10 Aug 2009 09:49:50 -0400 [thread overview]
Message-ID: <20090810134950.GA16276@infradead.org> (raw)
In-Reply-To: <1249906663-7572-2-git-send-email-jlayton@redhat.com>
On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote:
> get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast
> to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly
> to a positive signed value.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
> Acked-by: Steve French <smfrench@gmail.com>
Looks good, and I think it would be very good to still gets this into
2.6.31.
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2009-08-10 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-10 12:17 [PATCH 0/3] vfs: change sb->s_maxbytes to loff_t (try #2) Jeff Layton
2009-08-10 12:17 ` [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to signed Jeff Layton
2009-08-10 13:49 ` Christoph Hellwig [this message]
2009-08-10 14:08 ` Jeff Layton
2009-08-10 14:16 ` Christoph Hellwig
2009-08-10 12:17 ` [PATCH 2/3] vfs: remove redundant position check in do_sendfile Jeff Layton
2009-08-10 14:56 ` Johannes Weiner
2009-08-10 12:17 ` [PATCH 3/3] vfs: change sb->s_maxbytes to a loff_t Jeff Layton
2009-08-10 21:24 ` Mandeep Singh Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810134950.GA16276@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msb@google.com \
--cc=rlove@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).