From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to signed Date: Mon, 10 Aug 2009 09:49:50 -0400 Message-ID: <20090810134950.GA16276@infradead.org> References: <1249906663-7572-1-git-send-email-jlayton@redhat.com> <1249906663-7572-2-git-send-email-jlayton@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hch@infradead.org, rlove@google.com, msb@google.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org To: Jeff Layton Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:49617 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754743AbZHJNtw (ORCPT ); Mon, 10 Aug 2009 09:49:52 -0400 Content-Disposition: inline In-Reply-To: <1249906663-7572-2-git-send-email-jlayton@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote: > get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly > to a positive signed value. > > Signed-off-by: Jeff Layton > Reviewed-by: Johannes Weiner > Acked-by: Steve French Looks good, and I think it would be very good to still gets this into 2.6.31. Reviewed-by: Christoph Hellwig