From: Jens Axboe <jens.axboe@oracle.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: w@1wt.eu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] splice: update mtime and atime on files
Date: Wed, 19 Aug 2009 10:50:29 +0200 [thread overview]
Message-ID: <20090819085028.GU12579@kernel.dk> (raw)
In-Reply-To: <E1MdNM6-0003y3-4t@pomaz-ex.szeredi.hu>
On Tue, Aug 18 2009, Miklos Szeredi wrote:
> On Tue, 18 Aug 2009, Jens Axboe wrote:
> > I've never heard anyone complain about this, and I suspect that Miklos
> > found it from code inspection rather than experiencing an issue with it.
>
> Right, I found it by code inspection.
>
> > So while it can indeed be classified as a bug (and it is), the impact is
> > not huge.
> >
> > That said, I don't have a huge issue with shoving this in -stable. I
> > just don't think it's a big deal.
>
> I agree that it's not a huge issue, however it might be worth it to
> add it to -stable for the sake of distro kernels which are usually
> based on the long term stable branch. If new apps start to use the
> splice interface then we want those to work well on distros as well as
> the latest kernel.org kernels.
As I said, I don't have a problem with adding it to -stable, even if it
isn't a critical issue. The patch is straight forward and fixes a real
issue, so risk is low (and benefit high).
--
Jens Axboe
prev parent reply other threads:[~2009-08-19 8:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 15:05 [PATCH] splice: update mtime and atime on files Miklos Szeredi
2009-08-15 6:42 ` Jens Axboe
2009-08-18 5:00 ` Willy Tarreau
2009-08-18 8:35 ` Jens Axboe
2009-08-18 8:46 ` Willy Tarreau
2009-08-18 8:50 ` Jens Axboe
2009-08-18 11:59 ` Miklos Szeredi
2009-08-19 8:50 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090819085028.GU12579@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).