From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] splice: update mtime and atime on files Date: Wed, 19 Aug 2009 10:50:29 +0200 Message-ID: <20090819085028.GU12579@kernel.dk> References: <20090815064241.GE12579@kernel.dk> <20090818050027.GE11624@1wt.eu> <20090818083547.GK12579@kernel.dk> <20090818084625.GF18709@1wt.eu> <20090818085051.GM12579@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: w@1wt.eu, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Miklos Szeredi Return-path: Received: from brick.kernel.dk ([93.163.65.50]:45227 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbZHSIu1 (ORCPT ); Wed, 19 Aug 2009 04:50:27 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Aug 18 2009, Miklos Szeredi wrote: > On Tue, 18 Aug 2009, Jens Axboe wrote: > > I've never heard anyone complain about this, and I suspect that Miklos > > found it from code inspection rather than experiencing an issue with it. > > Right, I found it by code inspection. > > > So while it can indeed be classified as a bug (and it is), the impact is > > not huge. > > > > That said, I don't have a huge issue with shoving this in -stable. I > > just don't think it's a big deal. > > I agree that it's not a huge issue, however it might be worth it to > add it to -stable for the sake of distro kernels which are usually > based on the long term stable branch. If new apps start to use the > splice interface then we want those to work well on distros as well as > the latest kernel.org kernels. As I said, I don't have a problem with adding it to -stable, even if it isn't a critical issue. The patch is straight forward and fixes a real issue, so risk is low (and benefit high). -- Jens Axboe