From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [Ocfs2-devel] [PATCH 12/17] ocfs2: Update syncing after splicing to match generic version Date: Mon, 24 Aug 2009 11:40:09 -0700 Message-ID: <20090824184009.GC7698@mail.oracle.com> References: <1250875447-15622-1-git-send-email-jack@suse.cz> <1250875447-15622-13-git-send-email-jack@suse.cz> <20090824183543.GF2818@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , LKML , linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com To: Mark Fasheh Return-path: Received: from rcsinet12.oracle.com ([148.87.113.124]:62575 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753266AbZHXSlD (ORCPT ); Mon, 24 Aug 2009 14:41:03 -0400 Content-Disposition: inline In-Reply-To: <20090824183543.GF2818@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 24, 2009 at 11:35:43AM -0700, Mark Fasheh wrote: > On Fri, Aug 21, 2009 at 07:24:02PM +0200, Jan Kara wrote: > > Update ocfs2 specific splicing code to use generic syncing helper. The sync now > > does not happen under rw_lock because generic_write_sync() acquires i_mutex > > which ranks above rw_lock. That should not matter because standard fsync path > > does not hold it either. > > Thanks Jan, > > Acked-by: Mark Fasheh Me too! Acked-by: Joel Becker Joel -- A good programming language should have features that make the kind of people who use the phrase "software engineering" shake their heads disapprovingly. - Paul Graham Joel Becker Principal Software Developer Oracle E-mail: joel.becker@oracle.com Phone: (650) 506-8127