* Re: xfs compat_ioctl?
2009-08-31 12:30 ` Christoph Hellwig
@ 2009-08-31 12:57 ` Mark Lord
2009-08-31 12:59 ` Michael Tokarev
2009-08-31 18:14 ` Torsten Kaiser
2009-08-31 18:37 ` Tim Walberg
2 siblings, 1 reply; 14+ messages in thread
From: Mark Lord @ 2009-08-31 12:57 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
Christoph Hellwig wrote:
> On Mon, Aug 31, 2009 at 11:02:51AM +0400, Michael Tokarev wrote:
>> Hello!
>>
>> I tried to resize an xfs filesystem on 64bit 2.6.30 kernel
>> using 32bit userland, and that does not work, in dmesg I see:
>>
>> ioctl32(xfs_growfs:24426): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ffa56df4) on /mnt
>> ioctl32(xfs_growfs:24427): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ff991254) on /mnt
>>
>> so apparently there's no compat_ioctl layer for these ioctls.
>>
>> Are there any plans to add these? :)
>
> Are you sure you're testing 2.6.30? The copat ioctls were added in 2.6.28.
..
What command-line flags were you using, Michael ?
I just tried a simple "xfs_growfs -d" here, and it worked fine.
This is 2.6.31-rc7-64bit on top of a 32-bit userland.
Cheers
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-08-31 12:57 ` Mark Lord
@ 2009-08-31 12:59 ` Michael Tokarev
0 siblings, 0 replies; 14+ messages in thread
From: Michael Tokarev @ 2009-08-31 12:59 UTC (permalink / raw)
To: Mark Lord; +Cc: Christoph Hellwig, Linux-kernel, linux-fsdevel, xfs
Mark Lord wrote:
> Christoph Hellwig wrote:
>> On Mon, Aug 31, 2009 at 11:02:51AM +0400, Michael Tokarev wrote:
>>> Hello!
>>>
>>> I tried to resize an xfs filesystem on 64bit 2.6.30 kernel
>>> using 32bit userland, and that does not work, in dmesg I see:
>>>
>>> ioctl32(xfs_growfs:24426): Unknown cmd fd(3)
>>> cmd(400c586e){t:'X';sz:12} arg(ffa56df4) on /mnt
>>> ioctl32(xfs_growfs:24427): Unknown cmd fd(3)
>>> cmd(400c586e){t:'X';sz:12} arg(ff991254) on /mnt
>>>
>>> so apparently there's no compat_ioctl layer for these ioctls.
>>>
>>> Are there any plans to add these? :)
>>
>> Are you sure you're testing 2.6.30? The copat ioctls were added in
>> 2.6.28.
>
> What command-line flags were you using, Michael ?
>
> I just tried a simple "xfs_growfs -d" here, and it worked fine.
> This is 2.6.31-rc7-64bit on top of a 32-bit userland.
Damn. I rebooted to 2.6.27 to test something unrelated, forgot
about it, and later tried xfs_growfs -d, which failed as per above.
And yes indeed, in 2.6.30 everything works as expected.
Please excuse me for the noise.
/mjt
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: xfs compat_ioctl?
2009-08-31 12:30 ` Christoph Hellwig
2009-08-31 12:57 ` Mark Lord
@ 2009-08-31 18:14 ` Torsten Kaiser
2009-08-31 18:27 ` Christoph Hellwig
2009-08-31 18:37 ` Tim Walberg
2 siblings, 1 reply; 14+ messages in thread
From: Torsten Kaiser @ 2009-08-31 18:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
On Mon, Aug 31, 2009 at 2:30 PM, Christoph Hellwig<hch@infradead.org> wrote:
> On Mon, Aug 31, 2009 at 11:02:51AM +0400, Michael Tokarev wrote:
>> Hello!
>>
>> I tried to resize an xfs filesystem on 64bit 2.6.30 kernel
>> using 32bit userland, and that does not work, in dmesg I see:
>>
>> ioctl32(xfs_growfs:24426): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ffa56df4) on /mnt
>> ioctl32(xfs_growfs:24427): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ff991254) on /mnt
>>
>> so apparently there's no compat_ioctl layer for these ioctls.
>>
>> Are there any plans to add these? :)
>
> Are you sure you're testing 2.6.30? The copat ioctls were added in
> 2.6.28.
On a slightly related note: I also have a system with a 32bit userland
and a 64bit kernel.
After switching to the 64bit kernel, xfs_fsr was no longer working,
but that was caused by the then still missing compat ioctls.
Today I retried it, but it still fails:
XFS_IOC_SWAPEXT failed: ino=<number>: Invalid argument
Looking at the compat code SWAPEXT looks somewhat suspicious:
fs/xfs/linux-2.6/xfs_ioctl32.h defines XFS_IOC_SWAPEXT_32, but I can't
find a single place where this is used.
And in the big switch of xfs_compat_ioctl() the value XFS_IOC_SWAPEXT
is surrounded by contants that all end in 32.
I don't have any experience with the linux ioctl code, I only read
fs/xfs/linux-2.6/xfs_ioctl32.c, but for my untrained eye it looks like
there is a _32 missing.
Or am I misreading this completely?
Torsten
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-08-31 18:14 ` Torsten Kaiser
@ 2009-08-31 18:27 ` Christoph Hellwig
2009-08-31 18:42 ` Torsten Kaiser
2009-09-01 17:00 ` Torsten Kaiser
0 siblings, 2 replies; 14+ messages in thread
From: Christoph Hellwig @ 2009-08-31 18:27 UTC (permalink / raw)
To: Torsten Kaiser
Cc: Christoph Hellwig, Michael Tokarev, Linux-kernel, linux-fsdevel,
xfs
On Mon, Aug 31, 2009 at 08:14:58PM +0200, Torsten Kaiser wrote:
> On a slightly related note: I also have a system with a 32bit userland
> and a 64bit kernel.
> After switching to the 64bit kernel, xfs_fsr was no longer working,
> but that was caused by the then still missing compat ioctls.
>
> Today I retried it, but it still fails:
> XFS_IOC_SWAPEXT failed: ino=<number>: Invalid argument
>
> Looking at the compat code SWAPEXT looks somewhat suspicious:
>
> fs/xfs/linux-2.6/xfs_ioctl32.h defines XFS_IOC_SWAPEXT_32, but I can't
> find a single place where this is used.
> And in the big switch of xfs_compat_ioctl() the value XFS_IOC_SWAPEXT
> is surrounded by contants that all end in 32.
>
> I don't have any experience with the linux ioctl code, I only read
> fs/xfs/linux-2.6/xfs_ioctl32.c, but for my untrained eye it looks like
> there is a _32 missing.
>
> Or am I misreading this completely?
I think you are right, the constant used is incorrect. Does the small
patch below fix it for you?
Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
+++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
@@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
case XFS_IOC_GETVERSION_32:
cmd = _NATIVE_IOC(cmd, long);
return xfs_file_ioctl(filp, cmd, p);
- case XFS_IOC_SWAPEXT: {
+ case XFS_IOC_SWAPEXT_32: {
struct xfs_swapext sxp;
struct compat_xfs_swapext __user *sxu = arg;
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-08-31 18:27 ` Christoph Hellwig
@ 2009-08-31 18:42 ` Torsten Kaiser
2009-09-01 17:00 ` Torsten Kaiser
1 sibling, 0 replies; 14+ messages in thread
From: Torsten Kaiser @ 2009-08-31 18:42 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
> I think you are right, the constant used is incorrect. Does the small
> patch below fix it for you?
Thanks, I will try it tomorrow.
Torsten
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
> case XFS_IOC_GETVERSION_32:
> cmd = _NATIVE_IOC(cmd, long);
> return xfs_file_ioctl(filp, cmd, p);
> - case XFS_IOC_SWAPEXT: {
> + case XFS_IOC_SWAPEXT_32: {
> struct xfs_swapext sxp;
> struct compat_xfs_swapext __user *sxu = arg;
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-08-31 18:27 ` Christoph Hellwig
2009-08-31 18:42 ` Torsten Kaiser
@ 2009-09-01 17:00 ` Torsten Kaiser
2009-09-01 17:55 ` Eric Sandeen
1 sibling, 1 reply; 14+ messages in thread
From: Torsten Kaiser @ 2009-09-01 17:00 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
> I think you are right, the constant used is incorrect. Does the small
> patch below fix it for you?
Yes, after adding this patch, xfs_fsr works.
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
> case XFS_IOC_GETVERSION_32:
> cmd = _NATIVE_IOC(cmd, long);
> return xfs_file_ioctl(filp, cmd, p);
> - case XFS_IOC_SWAPEXT: {
> + case XFS_IOC_SWAPEXT_32: {
> struct xfs_swapext sxp;
> struct compat_xfs_swapext __user *sxu = arg;
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-09-01 17:00 ` Torsten Kaiser
@ 2009-09-01 17:55 ` Eric Sandeen
0 siblings, 0 replies; 14+ messages in thread
From: Eric Sandeen @ 2009-09-01 17:55 UTC (permalink / raw)
To: Torsten Kaiser
Cc: Christoph Hellwig, linux-fsdevel, Michael Tokarev, Linux-kernel,
xfs
Torsten Kaiser wrote:
> On Mon, Aug 31, 2009 at 8:27 PM, Christoph Hellwig<hch@infradead.org> wrote:
>> I think you are right, the constant used is incorrect. Does the small
>> patch below fix it for you?
>
> Yes, after adding this patch, xfs_fsr works.
Crud, sorry about that. I swear I ran 32-bit xfstests under a 64-bit
kernel, but I think we were lacking in fsr coverage....
-Eric
>> Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
>> ===================================================================
>> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
>> +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
>> @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
>> case XFS_IOC_GETVERSION_32:
>> cmd = _NATIVE_IOC(cmd, long);
>> return xfs_file_ioctl(filp, cmd, p);
>> - case XFS_IOC_SWAPEXT: {
>> + case XFS_IOC_SWAPEXT_32: {
>> struct xfs_swapext sxp;
>> struct compat_xfs_swapext __user *sxu = arg;
>>
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: xfs compat_ioctl?
2009-08-31 12:30 ` Christoph Hellwig
2009-08-31 12:57 ` Mark Lord
2009-08-31 18:14 ` Torsten Kaiser
@ 2009-08-31 18:37 ` Tim Walberg
2009-08-31 18:48 ` Christoph Hellwig
2 siblings, 1 reply; 14+ messages in thread
From: Tim Walberg @ 2009-08-31 18:37 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
[-- Attachment #1: Type: text/plain, Size: 2306 bytes --]
I still get these on 2.6.30.4 on sparc64 (32-bit userspace a la Debian etch):
sparcy:~# uname -a
Linux sparcy 2.6.30.4-sparcy #2 Sat Aug 1 21:14:46 CDT 2009 sparc64 GNU/Linux
sparcy:~# file $(which xfs_fsr)
/usr/sbin/xfs_fsr: ELF 32-bit MSB executable, SPARC32PLUS, V8+ Required, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, stripped
sparcy:~# dmesg | grep xfs | tail -5
[62457.467755] ioctl32(xfs_fsr:18816): Unknown cmd fd(7) cmd(c0a8586d){t:'X';sz:168} arg(00028e30) on /export
[62473.400273] ioctl32(xfs_fsr:18816): Unknown cmd fd(7) cmd(c0a8586d){t:'X';sz:168} arg(00028e30) on /export
[62481.928844] ioctl32(xfs_fsr:18816): Unknown cmd fd(7) cmd(c0a8586d){t:'X';sz:168} arg(00028e30) on /export
[62486.304567] ioctl32(xfs_fsr:18816): Unknown cmd fd(7) cmd(c0a8586d){t:'X';sz:168} arg(00028e30) on /export
[62490.833736] ioctl32(xfs_fsr:18816): Unknown cmd fd(7) cmd(c0a8586d){t:'X';sz:168} arg(00028e30) on /export
Haven't tried rolling my own xfs_progs binaries yet. xfs_db also fails with
a "Bus error" immediately on startup, but that may be a completely different
issue...
tw
On 08/31/2009 08:30 -0400, Christoph Hellwig wrote:
>> On Mon, Aug 31, 2009 at 11:02:51AM +0400, Michael Tokarev wrote:
>> > Hello!
>> >
>> > I tried to resize an xfs filesystem on 64bit 2.6.30 kernel
>> > using 32bit userland, and that does not work, in dmesg I see:
>> >
>> > ioctl32(xfs_growfs:24426): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ffa56df4) on /mnt
>> > ioctl32(xfs_growfs:24427): Unknown cmd fd(3) cmd(400c586e){t:'X';sz:12} arg(ff991254) on /mnt
>> >
>> > so apparently there's no compat_ioctl layer for these ioctls.
>> >
>> > Are there any plans to add these? :)
>>
>> Are you sure you're testing 2.6.30? The copat ioctls were added in
>> 2.6.28.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
End of included message
--
+----------------------+
| Tim Walberg |
| 830 Carriage Dr. |
| Algonquin, IL 60102 |
| twalberg@comcast.net |
+----------------------+
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: xfs compat_ioctl?
2009-08-31 18:37 ` Tim Walberg
@ 2009-08-31 18:48 ` Christoph Hellwig
2009-08-31 18:49 ` Christoph Hellwig
0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2009-08-31 18:48 UTC (permalink / raw)
To: Tim Walberg, Christoph Hellwig, Michael Tokarev, Linux-kernel,
linux-fsdevel <linux-fsdevel
On Mon, Aug 31, 2009 at 01:37:51PM -0500, Tim Walberg wrote:
> Linux sparcy 2.6.30.4-sparcy #2 Sat Aug 1 21:14:46 CDT 2009 sparc64 GNU/Linux
> sparcy:~# file $(which xfs_fsr)
> /usr/sbin/xfs_fsr: ELF 32-bit MSB executable, SPARC32PLUS, V8+ Required, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, stripped
I'll take a look at that, thanks.
> Haven't tried rolling my own xfs_progs binaries yet. xfs_db also fails with
> a "Bus error" immediately on startup, but that may be a completely different
> issue...
It's a problem with unaligned accesses which I fixed for xfsprogs-2.0.3
which was released yesterday.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: xfs compat_ioctl?
2009-08-31 18:48 ` Christoph Hellwig
@ 2009-08-31 18:49 ` Christoph Hellwig
2009-08-31 19:02 ` Tim Walberg
0 siblings, 1 reply; 14+ messages in thread
From: Christoph Hellwig @ 2009-08-31 18:49 UTC (permalink / raw)
To: Tim Walberg, Christoph Hellwig, Michael Tokarev, Linux-kernel,
linux-fsdevel <linux-fsdevel
On Mon, Aug 31, 2009 at 02:48:22PM -0400, Christoph Hellwig wrote:
> On Mon, Aug 31, 2009 at 01:37:51PM -0500, Tim Walberg wrote:
> > Linux sparcy 2.6.30.4-sparcy #2 Sat Aug 1 21:14:46 CDT 2009 sparc64 GNU/Linux
> > sparcy:~# file $(which xfs_fsr)
> > /usr/sbin/xfs_fsr: ELF 32-bit MSB executable, SPARC32PLUS, V8+ Required, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, stripped
>
> I'll take a look at that, thanks.
Err, sorry - is that with the patch I posted in this thread or without?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: xfs compat_ioctl?
2009-08-31 18:49 ` Christoph Hellwig
@ 2009-08-31 19:02 ` Tim Walberg
2009-09-02 11:51 ` Tim Walberg
0 siblings, 1 reply; 14+ messages in thread
From: Tim Walberg @ 2009-08-31 19:02 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Tim Walberg, Michael Tokarev, Linux-kernel, linux-fsdevel, xfs
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On 08/31/2009 14:49 -0400, Christoph Hellwig wrote:
>> On Mon, Aug 31, 2009 at 02:48:22PM -0400, Christoph Hellwig wrote:
>> > On Mon, Aug 31, 2009 at 01:37:51PM -0500, Tim Walberg wrote:
>> > > Linux sparcy 2.6.30.4-sparcy #2 Sat Aug 1 21:14:46 CDT 2009 sparc64 GNU/Linux
>> > > sparcy:~# file $(which xfs_fsr)
>> > > /usr/sbin/xfs_fsr: ELF 32-bit MSB executable, SPARC32PLUS, V8+ Required, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, stripped
>> >
>> > I'll take a look at that, thanks.
>>
>> Err, sorry - is that with the patch I posted in this thread or without?
End of included message
No, that's the generic 2.6.30.4... I can attempt with that patch as well, but
it might be a day or two...
tw
--
+----------------------+
| Tim Walberg |
| 830 Carriage Dr. |
| Algonquin, IL 60102 |
| twalberg@comcast.net |
+----------------------+
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: xfs compat_ioctl?
2009-08-31 19:02 ` Tim Walberg
@ 2009-09-02 11:51 ` Tim Walberg
0 siblings, 0 replies; 14+ messages in thread
From: Tim Walberg @ 2009-09-02 11:51 UTC (permalink / raw)
To: Tim Walberg, Christoph Hellwig, Linux-kernel, linux-fsdevel, xfs
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
Ok, that patch has fixed my issues with xfs_fsr. Now I just need to
pull a new copy of xfs_progs to get the xfs_db alignment issue fix...
Thanks,
tw
On 08/31/2009 14:02 -0500, Walberg, Tim wrote:
>>
>>
>> On 08/31/2009 14:49 -0400, Christoph Hellwig wrote:
>> >> On Mon, Aug 31, 2009 at 02:48:22PM -0400, Christoph Hellwig wrote:
>> >> > On Mon, Aug 31, 2009 at 01:37:51PM -0500, Tim Walberg wrote:
>> >> > > Linux sparcy 2.6.30.4-sparcy #2 Sat Aug 1 21:14:46 CDT 2009 sparc64 GNU/Linux
>> >> > > sparcy:~# file $(which xfs_fsr)
>> >> > > /usr/sbin/xfs_fsr: ELF 32-bit MSB executable, SPARC32PLUS, V8+ Required, version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux 2.6.18, stripped
>> >> >
>> >> > I'll take a look at that, thanks.
>> >>
>> >> Err, sorry - is that with the patch I posted in this thread or without?
>> End of included message
>>
>>
>> No, that's the generic 2.6.30.4... I can attempt with that patch as well, but
>> it might be a day or two...
>>
>> tw
>>
End of included message
--
twalberg@comcast.net
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread