From: Theodore Tso <tytso@mit.edu>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, hch@infradead.org,
akpm@linux-foundation.org, jack@suse.cz
Subject: Re: [PATCH 1/8] writeback: move super_block argument to struct writeback_control
Date: Tue, 1 Sep 2009 07:55:51 -0400 [thread overview]
Message-ID: <20090901115551.GA727@mit.edu> (raw)
In-Reply-To: <1251803946-9243-2-git-send-email-jens.axboe@oracle.com>
On Tue, Sep 01, 2009 at 01:18:59PM +0200, Jens Axboe wrote:
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> ---
> fs/ubifs/super.c | 3 ++-
> include/linux/fs.h | 3 +--
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> @@ -462,7 +463,7 @@ static int ubifs_sync_fs(struct super_block *sb, int wait)
> * the user be able to get more accurate results of 'statfs()' after
> * they synchronize the file system.
> */
> - generic_sync_sb_inodes(sb, &wbc);
> + generic_sync_sb_inodes(&wbc);
>
> /*
> * Synchronize write buffers, because 'ubifs_run_commit()' does not
I just tried compiling per-bdi v15 against the latest git HEAD, and
the compilation failed:
fs/ubifs/super.c: In function ‘ubifs_sync_fs’:
fs/ubifs/super.c:465: warning: passing argument 1 of ‘generic_sync_sb_inodes’ from incompatible pointer type
fs/ubifs/super.c:465: error: too many arguments to function ‘generic_sync_sb_inodes’
Looks like the latest version of fs/ubifs/super.c added a call to
generic_sync_sb_inodes that needs to be fixed up. Line 465:
generic_sync_sb_inodes(sb, &wbc);
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-09-01 11:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 11:18 [PATCH 0/8] Per-bdi writeback flusher threads v16 Jens Axboe
2009-09-01 11:18 ` [PATCH 1/8] writeback: move super_block argument to struct writeback_control Jens Axboe
2009-09-01 11:55 ` Theodore Tso [this message]
2009-09-01 11:57 ` Theodore Tso
2009-09-01 12:05 ` Jens Axboe
2009-09-01 14:06 ` Theodore Tso
2009-09-01 21:51 ` Christoph Hellwig
2009-09-02 6:45 ` Jens Axboe
2009-09-01 11:19 ` [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-09-01 11:19 ` [PATCH 3/8] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-09-01 11:19 ` [PATCH 4/8] writeback: get rid of pdflush completely Jens Axboe
2009-09-01 11:19 ` [PATCH 5/8] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-09-01 11:19 ` [PATCH 6/8] writeback: add name to backing_dev_info Jens Axboe
2009-09-01 11:19 ` [PATCH 7/8] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-09-01 11:19 ` [PATCH 8/8] vm: Add an tuning knob for vm.max_writeback_pages Jens Axboe
2009-09-01 18:38 ` Peter Zijlstra
2009-09-01 18:44 ` Christoph Hellwig
2009-09-01 20:27 ` Theodore Tso
2009-09-02 7:32 ` Peter Zijlstra
2009-09-02 7:35 ` Peter Zijlstra
2009-09-01 23:52 ` Jamie Lokier
2009-09-01 23:56 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901115551.GA727@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).