From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joel Becker <Joel.Becker@oracle.com>
Subject: Re: [PATCH 2/2] ocfs2: Use MAY_CREATE in
 ocfs2_permission()
Date: Thu, 3 Sep 2009 12:12:32 -0700
Message-ID: <20090903191232.GA11525@mail.oracle.com>
References: <1251940014-20963-1-git-send-email-joel.becker@oracle.com>
	<1251940014-20963-3-git-send-email-joel.becker@oracle.com>
	<4A9F1FCB.5020406@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: hch@infradead.org, viro@zeniv.linux.org.uk, ocfs2-devel@oss.oracle.com,
        linux-fsdevel@kernel.org
To: Sunil Mushran <sunil.mushran@oracle.com>
Return-path: <ocfs2-devel-bounces@oss.oracle.com>
Content-Disposition: inline
In-Reply-To: <4A9F1FCB.5020406@oracle.com>
List-Unsubscribe: <http://oss.oracle.com/mailman/listinfo/ocfs2-devel>,
	<mailto:ocfs2-devel-request@oss.oracle.com?subject=unsubscribe>
List-Archive: <http://oss.oracle.com/pipermail/ocfs2-devel>
List-Post: <mailto:ocfs2-devel@oss.oracle.com>
List-Help: <mailto:ocfs2-devel-request@oss.oracle.com?subject=help>
List-Subscribe: <http://oss.oracle.com/mailman/listinfo/ocfs2-devel>,
	<mailto:ocfs2-devel-request@oss.oracle.com?subject=subscribe>
Sender: ocfs2-devel-bounces@oss.oracle.com
Errors-To: ocfs2-devel-bounces@oss.oracle.com
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Sep 02, 2009 at 06:45:47PM -0700, Sunil Mushran wrote:
> Joel Becker wrote:
> >@@ -1108,6 +1117,10 @@ int ocfs2_permission(struct inode *inode, int mask)
> > 	ret = generic_permission(inode, mask, ocfs2_check_acl);
> > 	ocfs2_inode_unlock(inode, 0);
> >+
> >+	if (mask & MAY_CREATE)
> >+		ocfs2_unblock_signals(&oldset);
> >+
> > out:
> > 	mlog_exit(ret);
> > 	return ret;
> 
> Maybe I am missing something but shouldn't we be unblocking the signal
> after the out label.

	Yes.

Joel

-- 

"Heav'n hath no rage like love to hatred turn'd, nor Hell a fury,
 like a woman scorn'd."
        - William Congreve

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127