From: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
To: heiko.carstens@de.ibm.com
Cc: konishi.ryusuke@lab.ntt.co.jp, akpm@linux-foundation.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] nilfs2: fix format string compile warning (ino_t)
Date: Fri, 04 Sep 2009 15:55:14 +0900 (JST) [thread overview]
Message-ID: <20090904.155514.09563346.ryusuke@osrg.net> (raw)
In-Reply-To: <20090903154248.GA26842@osiris.boeblingen.de.ibm.com>
On Thu, 3 Sep 2009 17:42:48 +0200, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Unlike on most other architectures ino_t is an unsigned int on s390.
> So add an explicit cast to avoid this compile warning:
>
> fs/nilfs2/recovery.c: In function 'recover_dsync_blocks':
> fs/nilfs2/recovery.c:555: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'ino_t'
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> Patch applies on top of linux-next.
Applied, thanks!
Ryusuke Konishi
> fs/nilfs2/recovery.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-next/fs/nilfs2/recovery.c
> ===================================================================
> --- linux-next.orig/fs/nilfs2/recovery.c
> +++ linux-next/fs/nilfs2/recovery.c
> @@ -552,7 +552,8 @@ static int recover_dsync_blocks(struct n
> printk(KERN_WARNING
> "NILFS warning: error recovering data block "
> "(err=%d, ino=%lu, block-offset=%llu)\n",
> - err, rb->ino, (unsigned long long)rb->blkoff);
> + err, (unsigned long)rb->ino,
> + (unsigned long long)rb->blkoff);
> if (!err2)
> err2 = err;
> next:
> --
prev parent reply other threads:[~2009-09-04 6:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 15:42 [PATCH] nilfs2: fix format string compile warning (ino_t) Heiko Carstens
2009-09-04 6:55 ` Ryusuke Konishi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904.155514.09563346.ryusuke@osrg.net \
--to=konishi.ryusuke@lab.ntt.co.jp \
--cc=akpm@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).