* [PATCH] nilfs2: fix format string compile warning (ino_t)
@ 2009-09-03 15:42 Heiko Carstens
2009-09-04 6:55 ` Ryusuke Konishi
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2009-09-03 15:42 UTC (permalink / raw)
To: Ryusuke Konishi, Andrew Morton; +Cc: linux-fsdevel
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Unlike on most other architectures ino_t is an unsigned int on s390.
So add an explicit cast to avoid this compile warning:
fs/nilfs2/recovery.c: In function 'recover_dsync_blocks':
fs/nilfs2/recovery.c:555: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'ino_t'
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
Patch applies on top of linux-next.
fs/nilfs2/recovery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-next/fs/nilfs2/recovery.c
===================================================================
--- linux-next.orig/fs/nilfs2/recovery.c
+++ linux-next/fs/nilfs2/recovery.c
@@ -552,7 +552,8 @@ static int recover_dsync_blocks(struct n
printk(KERN_WARNING
"NILFS warning: error recovering data block "
"(err=%d, ino=%lu, block-offset=%llu)\n",
- err, rb->ino, (unsigned long long)rb->blkoff);
+ err, (unsigned long)rb->ino,
+ (unsigned long long)rb->blkoff);
if (!err2)
err2 = err;
next:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] nilfs2: fix format string compile warning (ino_t)
2009-09-03 15:42 [PATCH] nilfs2: fix format string compile warning (ino_t) Heiko Carstens
@ 2009-09-04 6:55 ` Ryusuke Konishi
0 siblings, 0 replies; 2+ messages in thread
From: Ryusuke Konishi @ 2009-09-04 6:55 UTC (permalink / raw)
To: heiko.carstens; +Cc: konishi.ryusuke, akpm, linux-fsdevel
On Thu, 3 Sep 2009 17:42:48 +0200, Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Unlike on most other architectures ino_t is an unsigned int on s390.
> So add an explicit cast to avoid this compile warning:
>
> fs/nilfs2/recovery.c: In function 'recover_dsync_blocks':
> fs/nilfs2/recovery.c:555: warning: format '%lu' expects type 'long unsigned int', but argument 3 has type 'ino_t'
>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> Patch applies on top of linux-next.
Applied, thanks!
Ryusuke Konishi
> fs/nilfs2/recovery.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-next/fs/nilfs2/recovery.c
> ===================================================================
> --- linux-next.orig/fs/nilfs2/recovery.c
> +++ linux-next/fs/nilfs2/recovery.c
> @@ -552,7 +552,8 @@ static int recover_dsync_blocks(struct n
> printk(KERN_WARNING
> "NILFS warning: error recovering data block "
> "(err=%d, ino=%lu, block-offset=%llu)\n",
> - err, rb->ino, (unsigned long long)rb->blkoff);
> + err, (unsigned long)rb->ino,
> + (unsigned long long)rb->blkoff);
> if (!err2)
> err2 = err;
> next:
> --
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-04 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-03 15:42 [PATCH] nilfs2: fix format string compile warning (ino_t) Heiko Carstens
2009-09-04 6:55 ` Ryusuke Konishi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).