linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
	Dave Chinner <david@fromorbit.com>,
	Chris Mason <chris.mason@oracle.com>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	xfs@oss.sgi.com
Subject: Re: ext4 writepages is making tiny bios?
Date: Fri, 4 Sep 2009 09:20:13 +0200	[thread overview]
Message-ID: <20090904072013.GR18599@kernel.dk> (raw)
In-Reply-To: <20090904001545.GA30759@mit.edu>

On Thu, Sep 03 2009, Theodore Tso wrote:
> On Thu, Sep 03, 2009 at 12:42:09PM -0400, Christoph Hellwig wrote:
> > > Careful:
> > > 
> > > -	tloff = min(tlast, startpage->index + 64);
> > > +	tloff = min(tlast, startpage->index + 8192);
> > > 
> > > That will cause 64k page machines to try to write back 512MB at a
> > > time. This will re-introduce similar to the behaviour in sles9 where
> > > writeback would only terminate at the end of an extent (because the
> > > mapping end wasn't capped like above).
> > 
> > Pretty good point, any applies to all the different things we discussed
> > recently.  Ted, should be maybe introduce a max_writeback_mb instead of
> > the max_writeback_pages in the VM, too?
> 
> Good point.
> 
> Jens, maybe we should replace my patch with this one, which makes the
> tunable in terms of megabytes instead of pages?

That is probably a better metric than 'pages', lets update it.

-- 
Jens Axboe


      reply	other threads:[~2009-09-04  7:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-01 18:44 ext4 writepages is making tiny bios? Chris Mason
2009-09-01 20:57 ` Theodore Tso
2009-09-01 21:27   ` Christoph Hellwig
2009-09-02  0:17     ` Chris Mason
2009-09-03  5:52     ` Dave Chinner
2009-09-03 16:42       ` Christoph Hellwig
2009-09-04  0:15         ` Theodore Tso
2009-09-04  7:20           ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904072013.GR18599@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=chris.mason@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).