From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [patch 04/33] fs: brlock vfsmount_lock Date: Fri, 4 Sep 2009 17:19:09 +0200 Message-ID: <20090904151908.GX18599@kernel.dk> References: <20090904065142.114706411@nick.local0.net> <20090904065534.447753909@nick.local0.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: npiggin@suse.de Return-path: Received: from brick.kernel.dk ([93.163.65.50]:36819 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756888AbZIDPTH (ORCPT ); Fri, 4 Sep 2009 11:19:07 -0400 Content-Disposition: inline In-Reply-To: <20090904065534.447753909@nick.local0.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 04 2009, npiggin@suse.de wrote: > Index: linux-2.6/fs/namei.c > =================================================================== > --- linux-2.6.orig/fs/namei.c > +++ linux-2.6/fs/namei.c > @@ -679,15 +679,16 @@ int follow_up(struct path *path) > { > struct vfsmount *parent; > struct dentry *mountpoint; > - spin_lock(&vfsmount_lock); > + > + vfsmount_read_unlock(); > parent = path->mnt->mnt_parent; > if (parent == path->mnt) { > - spin_unlock(&vfsmount_lock); > + vfsmount_read_unlock(); > return 0; Hmm, that looks a bit off. -- Jens Axboe