From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
chris.mason@oracle.com, david@fromorbit.com, tytso@mit.edu,
akpm@linux-foundation.org, jack@suse.cz
Subject: Re: [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info
Date: Fri, 4 Sep 2009 11:43:05 -0400 [thread overview]
Message-ID: <20090904154305.GA10002@infradead.org> (raw)
In-Reply-To: <20090904065357.GP18599@kernel.dk>
On Fri, Sep 04, 2009 at 08:53:57AM +0200, Jens Axboe wrote:
> > + if (wbc->sync_mode == WB_SYNC_ALL)
> > + bdi_wait_on_work_clear(&work);
> > }
>
> That doesn't work, you have to wait for on-stack work. So either we just
> punt and not do anything for WB_SYNC_NONE if the allocation fails, or we
> punt to stack and do the wait. Since it's a cleaning action and
> allocation fails, falling back to the stack and waiting seems like the
> most appropriate choice.
True, the wait needs to be unconditional. Updated version below.
But now that I look at it, I wonder if we should even bother with it.
bdi_start_writeback is only used in WC_SYNC_NONE mode in
balance_dirty_pages. So if we really run so much out of memory that we
can't allocate the bdi_work we might just throttle and wait for the
flusher thread to do it's work. That would get rid of all the
special cases for the on-stack bdi_work instances.
next prev parent reply other threads:[~2009-09-04 15:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 8:42 [PATCH 0/8] Per-bdi writeback flusher threads v17 Jens Axboe
2009-09-02 8:42 ` [PATCH 1/8] writeback: get rid of generic_sync_sb_inodes() export Jens Axboe
2009-09-02 10:13 ` Jan Kara
2009-09-02 10:26 ` Jens Axboe
2009-09-02 14:01 ` Jan Kara
2009-09-02 8:42 ` [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-09-04 2:46 ` Christoph Hellwig
2009-09-04 2:50 ` Christoph Hellwig
2009-09-04 7:19 ` Jens Axboe
2009-09-04 2:56 ` Christoph Hellwig
2009-09-04 6:53 ` Jens Axboe
2009-09-04 15:43 ` Christoph Hellwig [this message]
2009-09-06 18:43 ` Jens Axboe
2009-09-08 18:44 ` Christoph Hellwig
2009-09-11 7:47 ` Jens Axboe
2009-09-02 8:42 ` [PATCH 3/8] writeback: switch to per-bdi threads for flushing data Jens Axboe
2009-09-02 8:42 ` [PATCH 4/8] writeback: get rid of pdflush completely Jens Axboe
2009-09-02 8:42 ` [PATCH 5/8] writeback: add some debug inode list counters to bdi stats Jens Axboe
2009-09-02 8:42 ` [PATCH 6/8] writeback: add name to backing_dev_info Jens Axboe
2009-09-02 8:42 ` [PATCH 7/8] writeback: check for registered bdi in flusher add and inode dirty Jens Axboe
2009-09-02 8:42 ` [PATCH 8/8] vm: Add an tuning knob for vm.max_writeback_pages Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2009-09-08 9:23 [PATCH 0/8] Per-bdi writeback flusher threads v19 Jens Axboe
2009-09-08 9:23 ` [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-09-04 7:46 [PATCH 0/8] Per-bdi writeback flusher threads v18 Jens Axboe
2009-09-04 7:46 ` [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
2009-09-01 11:18 [PATCH 0/8] Per-bdi writeback flusher threads v16 Jens Axboe
2009-09-01 11:19 ` [PATCH 2/8] writeback: move dirty inodes from super_block to backing_dev_info Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090904154305.GA10002@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).