From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Piggin Subject: Re: [patch 09/33] fs: dcache scale dentry refcount Date: Mon, 7 Sep 2009 09:44:31 +0200 Message-ID: <20090907074431.GH1875@wotan.suse.de> References: <20090904065142.114706411@nick.local0.net> <20090904065535.281876981@nick.local0.net> <7e0fb38c0909061101t6b4f337cvf691814c28bcf50e@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Eric Paris Return-path: Received: from cantor.suse.de ([195.135.220.2]:44882 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbZIGHo3 (ORCPT ); Mon, 7 Sep 2009 03:44:29 -0400 Content-Disposition: inline In-Reply-To: <7e0fb38c0909061101t6b4f337cvf691814c28bcf50e@mail.gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Sep 06, 2009 at 02:01:05PM -0400, Eric Paris wrote: > On Fri, Sep 4, 2009 at 2:51 AM, wrote: > > And yet in this case we do check for dentry->d_parent == dentry. (my > unknowing self thinks we'd want to check in all places) I think you're right, I think we need checks there too... BTW Is there a way to test the fsnotify code? I thought inotify was supposed to be implemented with fsnotify, but I see quite a lot of duplicated (or very similar) code... We've also still got inotify calls in fs/ (inotify_umount_inodes). and CONFIG_INOTIFY and CONFIG_FSNOTIFY conditionals in there too. Would it be possible to move that out into fsnotify calls? (fsnotify_inode_init_once or whatever). (Sorry to hijack your good review comments :)) Thanks, Nick