From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamie Lokier Subject: Re: [PATCH 3/8] Simplify exec_permission_lite() further Date: Tue, 8 Sep 2009 15:40:12 +0100 Message-ID: <20090908144012.GB5579@shareable.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Kernel Mailing List , Al Viro , Linux Filesystem Mailing List , Eric Paris , Mimi Zohar , James Morris To: Linus Torvalds Return-path: Received: from mail2.shareable.org ([80.68.89.115]:51125 "EHLO mail2.shareable.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751030AbZIHOkU (ORCPT ); Tue, 8 Sep 2009 10:40:20 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Linus Torvalds wrote: > This function is only called for path components that are already known > to be directories (they have a '->lookup' method). So don't bother > doing that whole S_ISDIR() testing, A few years ago you briefly discussed diddling the VFS to accept objects which are both files and directories. That is, have ->lookup() and also can be read as regular files. I don't know if your thinking has changed, and I don't particularly care, only thought I'd remind in case it's something you'd like to support at some point. -- Jamie