From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH 3/8] Simplify exec_permission_lite() further Date: Tue, 8 Sep 2009 08:58:32 -0600 Message-ID: <20090908145832.GE26346@parisc-linux.org> References: <20090908144012.GB5579@shareable.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linus Torvalds , Linux Kernel Mailing List , Al Viro , Linux Filesystem Mailing List , Eric Paris , Mimi Zohar , James Morris To: Jamie Lokier Return-path: Received: from palinux.external.hp.com ([192.25.206.14]:51646 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750932AbZIHO6a (ORCPT ); Tue, 8 Sep 2009 10:58:30 -0400 Content-Disposition: inline In-Reply-To: <20090908144012.GB5579@shareable.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Sep 08, 2009 at 03:40:12PM +0100, Jamie Lokier wrote: > Linus Torvalds wrote: > > This function is only called for path components that are already known > > to be directories (they have a '->lookup' method). So don't bother > > doing that whole S_ISDIR() testing, > > A few years ago you briefly discussed diddling the VFS to accept > objects which are both files and directories. That is, have > ->lookup() and also can be read as regular files. > > I don't know if your thinking has changed, and I don't particularly > care, only thought I'd remind in case it's something you'd like to > support at some point. If it's being used as a component of a pathname, we're _using_ it as a directory, so it won't matter for this case. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."