From: Christoph Hellwig <hch@infradead.org>
To: P??draig Brady <P@draigBrady.com>
Cc: xfs@oss.sgi.com, CoreutilsBugs <bug-coreutils@gnu.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: fsetxattr() fails on a writable descriptor?
Date: Tue, 8 Sep 2009 14:40:49 -0400 [thread overview]
Message-ID: <20090908184049.GA22050@infradead.org> (raw)
In-Reply-To: <4AA6402D.8040209@draigBrady.com>
On Tue, Sep 08, 2009 at 12:29:49PM +0100, P??draig Brady wrote:
> fsetxattr() is failing for me when the permissions are readonly
> but the descriptor is writable as demonstrated by the program below.
> I've tried this on ext3 and ext4 with libattr-2.4.43-3.fc11.i586
> and linux-2.6.30.5-43.fc11.i586
That's not XFS specifci behaviour. For all xattr operations, fd-based
or not we always do the full permission checks, and have done so since
day one. Check the routined xattr_permission in fs/xattr.c of the
kernel tree. It seems a bit unusual, but I'm not sure changing it now
is a good idea - the xattr support has been around for a long time.
next parent reply other threads:[~2009-09-08 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1251987642.3855.36.camel@dhcp-lab-219.englab.brq.redhat.com>
[not found] ` <4AA1A3E6.2020606@draigBrady.com>
[not found] ` <87k50den1e.fsf@meyering.net>
[not found] ` <1252309787.3852.8.camel@dhcp-lab-219.englab.brq.redhat.com>
[not found] ` <4AA4C950.3080303@draigBrady.com>
[not found] ` <1252318482.3852.18.camel@dhcp-lab-219.englab.brq.redhat.com>
[not found] ` <4AA6402D.8040209@draigBrady.com>
2009-09-08 18:40 ` Christoph Hellwig [this message]
2009-09-09 21:23 ` fsetxattr() fails on a writable descriptor? Pádraig Brady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908184049.GA22050@infradead.org \
--to=hch@infradead.org \
--cc=P@draigBrady.com \
--cc=bug-coreutils@gnu.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).