From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 8/8] vm: Add an tuning knob for vm.max_writeback_mb Date: Wed, 9 Sep 2009 08:51:48 -0400 Message-ID: <20090909125148.GA2834@infradead.org> References: <1252401791-22463-9-git-send-email-jens.axboe@oracle.com> <4AA633FD.3080006@gmail.com> <1252425983.7746.120.camel@twins> <20090908162936.GA2975@think> <20090909092901.GA24185@localhost> <20090909122805.GA30238@infradead.org> <20090909123223.GB23006@localhost> <20090909123746.GB18599@kernel.dk> <20090909124328.GA7747@infradead.org> <20090909124450.GC18599@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Wu Fengguang , Chris Mason , Peter Zijlstra , Artem Bityutskiy , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "david@fromorbit.com" , "akpm@linux-foundation.org" , "jack@suse.cz" , Theodore Ts'o To: Jens Axboe Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:36439 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbZIIMvs (ORCPT ); Wed, 9 Sep 2009 08:51:48 -0400 Content-Disposition: inline In-Reply-To: <20090909124450.GC18599@kernel.dk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Sep 09, 2009 at 02:44:50PM +0200, Jens Axboe wrote: > > bdi_start_writeback and not writeback_inodes_wbc from > > balance_dirty_pages. But you sent our another spin or two afer those, > > so maybe it changed again. > > Yes, that's the very end check, the old code does the same. Further up > it does writeback_inodes_wbc() if we are over the threshold. Aehm, true. It was still a sync_inodes_wbc in my tree..