From: Wu Fengguang <fengguang.wu@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>, Al Viro <viro@zeniv.linux.org.uk>,
Nick Piggin <npiggin@suse.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] libfs: return error code on failed attr set
Date: Sat, 12 Sep 2009 09:20:15 +0800 [thread overview]
Message-ID: <20090912012015.GA6281@localhost> (raw)
In-Reply-To: <20090911182930.GA13500@lst.de>
On Sat, Sep 12, 2009 at 02:29:30AM +0800, Christoph Hellwig wrote:
> On Fri, Sep 11, 2009 at 06:50:31PM +0800, Wu Fengguang wrote:
> > Currently all simple_attr.set handlers return 0 on success and negative
> > codes on error. Fix simple_attr_write() to return these error codes.
>
> Looks good to me assuming you actually audited all the implementations
> to do the right thing.
Yes I checked all DEFINE_SIMPLE_ATTRIBUTE users. All the _set()
handlers returns 0 for success and negative error code for failure.
Thanks,
Fengguang
prev parent reply other threads:[~2009-09-12 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 10:50 [PATCH] libfs: return error code on failed attr set Wu Fengguang
2009-09-11 18:29 ` Christoph Hellwig
2009-09-12 1:20 ` Wu Fengguang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090912012015.GA6281@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).