From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wu Fengguang <fengguang.wu@intel.com>
Subject: Re: [PATCH] libfs: return error code on failed attr set
Date: Sat, 12 Sep 2009 09:20:15 +0800
Message-ID: <20090912012015.GA6281@localhost>
References: <20090911105031.GA17315@localhost> <20090911182930.GA13500@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Theodore Ts'o <tytso@mit.edu>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Nick Piggin <npiggin@suse.de>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga03.intel.com ([143.182.124.21]:65452 "EHLO mga03.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752660AbZILBUW (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 11 Sep 2009 21:20:22 -0400
Content-Disposition: inline
In-Reply-To: <20090911182930.GA13500@lst.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Sep 12, 2009 at 02:29:30AM +0800, Christoph Hellwig wrote:
> On Fri, Sep 11, 2009 at 06:50:31PM +0800, Wu Fengguang wrote:
> > Currently all simple_attr.set handlers return 0 on success and negative
> > codes on error. Fix simple_attr_write() to return these error codes.
> 
> Looks good to me assuming you actually audited all the implementations
> to do the right thing.

Yes I checked all DEFINE_SIMPLE_ATTRIBUTE users. All the _set()
handlers returns 0 for success and negative error code for failure.

Thanks,
Fengguang