From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Axboe <jens.axboe@oracle.com>
Subject: Re: [PATCH 09/11] writeback: separate starting of sync vs
	opportunistic writeback
Date: Wed, 16 Sep 2009 15:07:06 +0200
Message-ID: <20090916130705.GO23126@kernel.dk>
References: <1253038617-30204-1-git-send-email-jens.axboe@oracle.com> <1253038617-30204-10-git-send-email-jens.axboe@oracle.com> <20090916130506.GF26030@duck.suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	chris.mason@oracle.com, hch@infradead.org, tytso@mit.edu,
	akpm@linux-foundation.org, trond.myklebust@fys.uio.no
To: Jan Kara <jack@suse.cz>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1759056AbZIPNHH@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20090916130506.GF26030@duck.suse.cz>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Wed, Sep 16 2009, Jan Kara wrote:
> On Tue 15-09-09 20:16:55, Jens Axboe wrote:
> > bdi_start_writeback() is currently split into two paths, one for
> > WB_SYNC_NONE and one for WB_SYNC_ALL. Add bdi_sync_writeback()
> > for WB_SYNC_ALL writeback and let bdi_start_writeback() handle
> > only WB_SYNC_NONE.
> > 
> > Push down the writeback_control allocation and only accept the
> > parameters that make sense for each function. This cleans up
> > the API considerably.
>   Nice cleanup!
> 
> > @@ -771,6 +798,8 @@ static long wb_check_old_data_flush(struct bdi_writeback *wb)
> >  		struct wb_writeback_args args = {
> >  			.nr_pages	= nr_pages,
> >  			.sync_mode	= WB_SYNC_NONE,
> > +			.for_kupdate	= 1,
> > +			.range_cyclic	= 1,
> >  		};
> >  
> >  		return wb_writeback(wb, &args);
>   This chunk should be in patch number 4.

Yeah, I wonder why that snuck into this one...

-- 
Jens Axboe