linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	viro@zeniv.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH] vfs: new FROM_ACCESS flag
Date: Mon, 21 Sep 2009 09:20:09 +0100	[thread overview]
Message-ID: <20090921082008.GB20006@shareable.org> (raw)
In-Reply-To: <20090921013048.2763.1494.stgit@paris.rdu.redhat.com>

Eric Paris wrote:
> This new acc_mode flag is just to tell the security system this
> inode permission check is from the access system call.  The security
> system can use this information as it finds appropriete.  In
> particular SELinux plans to use this flag to alter what we choose to
> audit and what we do not choose to audit.

Does "as it finds appropriate" mean robust applications should try an
operation anyway even if access() says no from now on?

Btw, since you're looking at access(), the kernel could do with
euidaccess() or a flag ACCESS_EUID.  (Either would be trivial to implement).

Glibc provides eaccess/euidaccess functions, but they work by calling
stat() and checking the mode bits when euid != ruid || egid != rgid,
which is clearly not very nice with ACLs, and perhaps not ideal for
SELinux's auditing of access calls either.

-- Jamie

  reply	other threads:[~2009-09-21  8:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21  1:30 [PATCH] vfs: new FROM_ACCESS flag Eric Paris
2009-09-21  8:20 ` Jamie Lokier [this message]
2009-09-22 13:56 ` Christoph Hellwig
2009-09-22 17:28   ` Eric Paris
2009-09-22 20:06     ` Christoph Hellwig
2009-09-23  8:48       ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090921082008.GB20006@shareable.org \
    --to=jamie@shareable.org \
    --cc=eparis@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).