From: Al Viro <viro@ZenIV.linux.org.uk>
To: akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, mszeredi@suse.cz,
Valdis.Kletnieks@vt.edu, agruen@suse.de, hch@lst.de,
hugh.dickins@tiscali.co.uk, matthew@wil.cx
Subject: Re: [patch 20/21] vfs: no "(unreachable)" prefix for SYSVIPC maps in /proc/PID/maps
Date: Mon, 21 Sep 2009 11:04:51 +0100 [thread overview]
Message-ID: <20090921100451.GJ5858@ZenIV.linux.org.uk> (raw)
In-Reply-To: <200909182006.n8IK62Db019767@imap1.linux-foundation.org>
On Fri, Sep 18, 2009 at 01:06:02PM -0700, akpm@linux-foundation.org wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> The patch
>
> "vfs: fix d_path() for unreachable paths"
>
> generally changed d_path() to report unreachable paths with a special
> prefix. This has an effect on /proc/${PID}/maps as well for memory maps
> set up with shmem_file_setup() or hugetlb_file_setup(). These functions
> set up unlinked files under a kernel-private vfsmount. Since this
> vfsmount is unreachable from userspace, these maps will be reported with
> the "(unreachable)" prefix.
>
> This is undesirable, because it changes the kernel ABI and might break
> applications for no good reason.
I'd rather see 17, 19 and 20 collapsed...
next prev parent reply other threads:[~2009-09-21 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-18 20:06 [patch 20/21] vfs: no "(unreachable)" prefix for SYSVIPC maps in /proc/PID/maps akpm
2009-09-21 10:04 ` Al Viro [this message]
2009-09-21 10:07 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090921100451.GJ5858@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Valdis.Kletnieks@vt.edu \
--cc=agruen@suse.de \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=mszeredi@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).