From mboxrd@z Thu Jan  1 00:00:00 1970
From: Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [patch 00/11] new truncate sequence
Date: Wed, 23 Sep 2009 00:27:42 +0100
Message-ID: <20090922232742.GI14381@ZenIV.linux.org.uk>
References: <20090820163504.131529718@suse.de> <20090922150444.GA14566@ZenIV.linux.org.uk> <20090922200042.GA27015@lst.de> <20090922215138.GH14381@ZenIV.linux.org.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: npiggin@suse.de, Andrew Morton <akpm@linux-foundation.org>,
	linux-fsdevel@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:55863 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752896AbZIVX1k (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 22 Sep 2009 19:27:40 -0400
Content-Disposition: inline
In-Reply-To: <20090922215138.GH14381@ZenIV.linux.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Sep 22, 2009 at 10:51:38PM +0100, Al Viro wrote:
> It is...  I really don't like some parts of that:
> 	* failing on foo_truncate() is all nice and proper, but
> what to do about the quota transfer that has already happened?
> Note that e.g. ext2_setattr() simply doesn't change uid/gid in
> case of ext2_setsize() failure.  It does transfer quota, though.
> And yes, nfsd can produce calls with both ATTR_SIZE and ATTR_UID
> set.
> 	* way, _way_ too much boilerplate around the aforementioned
> quota transfers.
> 	* if we don't do quota handling for minix and sysv (fair enough,
> no quota support implemented for those), why the devil are we doing it
> in simple_setattr()?
> 
> Anyway, #new-truncate in the usual VFS tree contains all "new truncate
> scheme" stuff I've collected from the lists so far.  Additions are welcome...

BTW, why are we messing with truncation in ->write_end() e.g. for ext2?