From: Jamie Lokier <jamie@shareable.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] vfs: new FROM_ACCESS flag
Date: Wed, 23 Sep 2009 09:48:16 +0100 [thread overview]
Message-ID: <20090923084816.GA7687@shareable.org> (raw)
In-Reply-To: <20090922200635.GB28826@infradead.org>
Christoph Hellwig wrote:
> On Tue, Sep 22, 2009 at 01:28:46PM -0400, Eric Paris wrote:
> > > only using MAY_ACCESS for calles from access() insteaf of introducing
> > > a FROM_ACCESS flag and causing lots of naming confusion.
> >
> > What would you think of a new, MUST_REVALIDATE_PERMS which will do what
> > MAY_ACCESS does today. MAY_ACCESS would be just for access(2) and would
> > be the flag that I use for SELinux?
>
> Yeah, something like this. I don't like the MUST_REVALIDATE_PERMS name
> too much, but unless someone comes up with a better one I can live with
> it.
MAY_ACCESS is used in only these places:
- access/faccessat
- chdir/fchdir
- chroot
And it is checked in only two easy to change places: nfs/dir.c and
fuse/dir.c.
Therefore how about MAY_CHDIR.
-- Jamie
prev parent reply other threads:[~2009-09-23 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 1:30 [PATCH] vfs: new FROM_ACCESS flag Eric Paris
2009-09-21 8:20 ` Jamie Lokier
2009-09-22 13:56 ` Christoph Hellwig
2009-09-22 17:28 ` Eric Paris
2009-09-22 20:06 ` Christoph Hellwig
2009-09-23 8:48 ` Jamie Lokier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923084816.GA7687@shareable.org \
--to=jamie@shareable.org \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).