From: Christoph Hellwig <hch@lst.de>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH] md: stop using do_sync_mapping_range
Date: Wed, 23 Sep 2009 15:18:22 +0200 [thread overview]
Message-ID: <20090923131822.GA12287@lst.de> (raw)
It's a very awkward way to write out all data and wait for it, so just
call filemap_write_and_wait. I still can't figure what the point of
all this is, so a comment would surely be helpful.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: vfs-2.6.git/drivers/md/bitmap.c
===================================================================
--- vfs-2.6.git.orig/drivers/md/bitmap.c 2009-09-22 14:31:08.698262797 -0300
+++ vfs-2.6.git/drivers/md/bitmap.c 2009-09-22 14:33:01.573762756 -0300
@@ -1621,10 +1621,7 @@ int bitmap_create(mddev_t *mddev)
bitmap->offset = mddev->bitmap_offset;
if (file) {
get_file(file);
- do_sync_mapping_range(file->f_mapping, 0, LLONG_MAX,
- SYNC_FILE_RANGE_WAIT_BEFORE |
- SYNC_FILE_RANGE_WRITE |
- SYNC_FILE_RANGE_WAIT_AFTER);
+ filemap_write_and_wait(file->f_mapping);
}
/* read superblock from bitmap file (this sets bitmap->chunksize) */
err = bitmap_read_sb(bitmap);
next reply other threads:[~2009-09-23 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 13:18 Christoph Hellwig [this message]
2009-09-23 13:47 ` [PATCH] md: stop using do_sync_mapping_range Jamie Lokier
2009-09-26 15:11 ` Christoph Hellwig
2009-09-23 22:52 ` Neil Brown
2009-09-26 15:13 ` Christoph Hellwig
2009-09-26 21:51 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090923131822.GA12287@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).